[WEB-3476] fix: attachment item

[anmolsinghbhatia]

Description

This PR fixes the issue where the attachment owner’s avatar was not rendered correctly when adding an attachment.

Type of Change

• Bug fix

References

[WEB-3476]

Summary by CodeRabbit

• Bug Fixes
  • Adjusted attachment tooltips so they now display the original uploader’s name along with the corresponding upload date, providing clearer and more accurate information for users.

[coderabbitai]

Walkthrough

This pull request updates the conditional rendering logic in the IssueAttachmentsListItem component. The condition now checks for attachment?.created_by instead of attachment?.updated_by, shifting the displayed user information from the last updater to the original creator. Additionally, the tooltip has been updated to show the creator's display name along with the upload date derived from attachment.updated_at. The overall component structure and event handling remain unchanged.

Changes

File	Change Summary
web/core/.../issues/attachment/attachment-list-item.tsx	Replaced check from attachment?.updated_by to attachment?.created_by and updated tooltip content to display creator's name and upload date using updated_at.

Possibly related PRs

• [WEB-3377] fix: attachment item avatar #6650: Addresses a similar change from using updated_by to created_by in the IssueAttachmentsListItem component.
• [WEB-3439] fix: work item attachment mutation #6655: Involves adding the created_by field to the IssueAttachmentLiteSerializer, complementing the display changes in this PR.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• sriramveeraghanta
• prateekshourya29
• aaryan610

Poem

I'm a little rabbit with a playful code hop,
Skipping through logic non-stop,
Changed the check to the creator's cue,
Updated the tooltip with a fresher view,
In the garden of code, I joyfully prance,
Celebrating fixes in this delightful dance!
🐰💻

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/core/components/issues/attachment/attachment-list-item.tsx (1)

72-75: Consider consistency between displayed user and timestamp.

While the code now correctly shows the creator's details (attachment?.created_by), it's still using attachment.updated_at for the timestamp. For consistency, consider using attachment.created_at instead to show when the file was originally uploaded rather than when it was last modified.

 <Tooltip
   isMobile={isMobile}
   tooltipContent={`${
     getUserDetails(attachment?.created_by)?.display_name ?? ""
-  } uploaded on ${renderFormattedDate(attachment.updated_at)}`}
+  } uploaded on ${renderFormattedDate(attachment.created_at)}`}
 >

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f899744 and eab6e4d.

📒 Files selected for processing (1)

• web/core/components/issues/attachment/attachment-list-item.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

web/core/components/issues/attachment/attachment-list-item.tsx (2)

69-82: Fixed avatar rendering to show attachment creator instead of updater.

The change from updated_by to created_by aligns with the PR objective of correctly displaying the attachment owner's avatar. This addresses the bug where the avatar wasn't showing the right person.

🧰 Tools

🪛 Biome (1.9.4)

[error] 70-81: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)

---

78-78: LGTM - Avatar component properly uses the creator ID.

The ButtonAvatars component is now correctly passed the creator's ID via the attachment?.created_by prop.