Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: italian translations #6692

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Mar 3, 2025

Description

This PR adds support for Italian translations.

Type of Change

  • Feature

Summary by CodeRabbit

  • New Features
    • Expanded language support by adding Italian.
    • Introduced comprehensive Italian translations for navigation, authentication, error messages, and project settings.
    • Enhanced the translation loader to dynamically support the new Italian language option.
  • Style
    • Adjusted layout of the date range selector for better adaptability.
    • Updated placeholder text for the date range selection to improve clarity.

Copy link
Contributor

coderabbitai bot commented Mar 3, 2025

Walkthrough

The changes add support for the Italian language in the application. The update includes a new entry for Italian in the SUPPORTED_LANGUAGES array and updates the TLanguage type definition. A new Italian translations JSON file is introduced, and the translation loader has been modified to handle dynamic imports for Italian.

Changes

File(s) Summary
packages/i18n/src/constants/language.ts
packages/i18n/src/types/language.ts
Added Italian support by updating the SUPPORTED_LANGUAGES array and TLanguage type definition
packages/i18n/src/locales/it/translations.json Added new Italian translations covering multiple UI sections
packages/i18n/src/store/index.ts Modified importLanguageFile to dynamically load the Italian translations file
web/core/components/modules/analytics-sidebar/root.tsx Updated class name for a date range selector and changed placeholder text for target_date

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant TS as TranslationStore
    participant IT as ItalianTranslations File

    U->>TS: Request translations for "it"
    TS->>TS: Process language switch (case "it")
    TS->>IT: Import "../locales/it/translations.json"
    IT-->>TS: Return Italian translations data
    TS-->>U: Deliver loaded Italian translations
Loading

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • prateekshourya29

Poem

I'm a rabbit hopping through code all day,
With Italian words in the mix, hooray!
New translations bloom like a vibrant bouquet,
Carrots and code leap in joyful array,
Celebrating change in our own rabbit way!

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/i18n/src/constants/language.ts (1)

12-12: Consider using native language name for consistency.

The language label for Italian is currently displayed in English ("Italian"). For consistency with other language entries like "Français" and "Español" which use their native language names, consider using "Italiano" instead.

-  { label: "Italian", value: "it" },
+  { label: "Italiano", value: "it" },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0188cab and 6ce8d19.

📒 Files selected for processing (4)
  • packages/i18n/src/constants/language.ts (1 hunks)
  • packages/i18n/src/locales/it/translations.json (1 hunks)
  • packages/i18n/src/store/index.ts (1 hunks)
  • packages/i18n/src/types/language.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/i18n/src/locales/it/translations.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
packages/i18n/src/types/language.ts (1)

1-1: LGTM! Type definition properly updated for Italian.

The TLanguage type definition has been correctly updated to include the "it" language code, maintaining type safety throughout the application.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
web/core/components/modules/analytics-sidebar/root.tsx (2)

420-420: Width constraint removal improves localization support

The removal of the w-3/5 width constraint is a good change for internationalization. Fixed width constraints can cause UI issues when text lengths vary across different languages, which is common when adding new translations like Italian. This change allows the date range component to adapt to the content size.


446-446: Improved terminology consistency with "end_date"

Changing from t("target_date") to t("end_date") provides clearer and more consistent terminology, which is important for translations. The term "end date" is more universally understood and likely more consistent with other parts of the UI, making it easier for Italian users to understand the date range concept.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ce8d19 and 68c6cd5.

📒 Files selected for processing (1)
  • web/core/components/modules/analytics-sidebar/root.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)

@sriramveeraghanta sriramveeraghanta merged commit f899744 into preview Mar 3, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the feat-italian-translations branch March 3, 2025 14:26
sriramveeraghanta added a commit that referenced this pull request Mar 5, 2025
* fix: issue activity for project id validation (#6668)

* fix: work item attachment count mutation (#6670)

* updated the action to modify the release build assets (#6669)

* feat: russian translation (#6666)

* chore: ru translation updated (#6672)

* fix: state drop down refactor

* fix: intake work item creation refactor

* fix: cleanup for deprecated functions

* fix: date range picker on cycles and modules list (#6676)

* fix: Handled workspace switcher closing on click

* fix: replaced date range picker with date picker at some places

* chore: add common translation keys (#6688)

* chore: add missing translation keys

* chore: add russian translation keys

* fix: issue activity task (#6689)

* changed github workflow action ubuntu version to `ubuntu-22.04` (#6683)

* chore: update russian translation (#6682)

* chore: update russian translation

* chore: rename issues to work items in russian translation

* [PE-275] chore: editor line spacing variables (#6678)

* chore: variable editor line spacing

* chore: variable list spacing

---------

Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com>

* [WEB-3475] fix: cycle dates dropdown (#6690)

* fix: Handled workspace switcher closing on click

* fix: Cycle date picker

* fix: Made onSelect optional in range range component

* fix: module date picker (#6691)

* fix: Handled workspace switcher closing on click

* fix: reverted module date picker changes

* chore: extended sidebar improvement (#6693)

* feat: italian translations (#6692)

* Create translations.json - ITALIAN translation (#6667)

* chore: italian translation updated

* feat: italian translation added

* fix: module end date translation

---------

Co-authored-by: Nicolas Bossi <nicolasbossi@gmail.com>
Co-authored-by: gakshita <akshitagoyal1516@gmail.com>

* fix: attachment item created by (#6695)

* fix: module flicker issue on property updation (#6699)

* [WEB-3477] fix: mutation issue on moving work items for a manually ended cycle (#6696)

* fix: package version update

* fix: esbuild version fix

* fix: package license repliation

* [WEB-3488] improvement: assignee validation for work item creation (#6701)

* fix: work item assignee update validation (#6704)

---------

Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com>
Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com>
Co-authored-by: Manish Gupta <59428681+mguptahub@users.noreply.github.com>
Co-authored-by: Nikita Mitasov <32384814+ch4og@users.noreply.github.com>
Co-authored-by: Akshita Goyal <36129505+gakshita@users.noreply.github.com>
Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Co-authored-by: Akshat Jain <akshatjain9782@gmail.com>
Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com>
Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com>
Co-authored-by: Nicolas Bossi <nicolasbossi@gmail.com>
Co-authored-by: gakshita <akshitagoyal1516@gmail.com>
Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
@sriramveeraghanta sriramveeraghanta added this to the v0.25.1 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟enhancement New feature or request 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants