fix: issue activity for project id validation

[pablohashescobar]

Description

fix: issue activity project id validation for uuid

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Test Scenarios

• test all updates to issue is creating an activity

Summary by CodeRabbit

• Bug Fixes

  • Improved input validation to ensure robust handling of identifier values, enhancing overall system stability.

• Chores

  • Implemented minor formatting adjustments to boost code readability and maintainability.

[coderabbitai]

Walkthrough

This change updates the issue_activity function in the apiserver/plane/bgtasks/issue_activities_task.py file by converting the project_id to a string before validating it with is_valid_uuid. This ensures that the validation function consistently receives the appropriate data type. Additionally, an empty line was added after the import statements to improve code readability. The overall control flow and logic remain unchanged.

Changes

File	Change Summary
apiserver/…/issue_activities_task.py	Updated issue_activity to cast project_id to a string before calling is_valid_uuid and added an empty line post-imports for improved readability.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant IssueActivity
    participant Validator
    Caller->>IssueActivity: Invoke issue_activity with project_id
    IssueActivity->>IssueActivity: Convert project_id to string
    IssueActivity->>Validator: Call is_valid_uuid(project_id)
    Validator-->>IssueActivity: Return validation result
    IssueActivity-->>Caller: Continue with processing

Loading

Possibly related PRs

• [WEB-2486] Fix: archive page break issue resolved #5644: Involved handling of the project_id variable to ensure appropriate data types are used during validation.
• [WEB-2817] fix: creating a new sub-issue from workspace level #6169: Addressed a bug with correct usage of project_id in the createUpdateModalData object, related to the same data type concerns.

Suggested labels

⚙️backend

Suggested reviewers

• sriramveeraghanta
• anmolsinghbhatia

Poem

I'm a happy rabbit, coding with delight,
Hopping over bugs from morning till night.
With strings aligned and UUIDs sorted just right,
Our code marches on—so tidy and bright.
A small change today, a giant leap in sight!
🐇💻 Let's celebrate this coding flight!

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f70eae2 and 1418ca0.

📒 Files selected for processing (1)

• apiserver/plane/bgtasks/issue_activities_task.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

apiserver/plane/bgtasks/issue_activities_task.py (1)

37-37: Good improvement on code structure.

Adding this empty line follows Python PEP 8 style guidelines by separating imports from function definitions, improving code readability.

[coderabbitai]

⚠️ Potential issue

Excellent bugfix for project ID validation.

Converting the project_id to a string before validation ensures that the is_valid_uuid function always receives the expected string type, regardless of how the project_id is passed to the function. This addresses the validation issue mentioned in the PR objectives and makes the code more robust against type-related errors.