[WEB-3475] fix: cycle dates dropdown

[gakshita]

Description

This PR changes the cycle dates on cycle page to read only and changes the side peek overview date picker back to date range picker

Summary by CodeRabbit

• New Features
  • Introduced a unified date range selector that consolidates start and end date inputs into a single, streamlined interface.
• Refactor
  • Updated the update flow to work asynchronously and simplified the date selection logic across components, reducing redundant validations for a smoother user experience.
  • Removed outdated components and associated validation logic to enhance clarity and usability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request refactors date handling across cycle-related components. The changes switch from single-date selection with a DateDropdown component to a unified DateRangeDropdown for selecting a date range. Updates include modifying function signatures (e.g., handleDateChange now accepts separate start and end dates) and making the submitChanges function asynchronous in the sidebar header component. Furthermore, validation logic and extraneous imports have been removed in the list item action component, and the date range dropdown’s internal state update has been eliminated.

Changes

File(s)	Change Summary
web/core/components/cycles/analytics-sidebar/.../sidebar-header.tsx web/core/components/cycles/list/.../cycle-list-item-action.tsx	Replaced single date selection (DateDropdown) with a unified DateRangeDropdown. Updated handleDateChange to accept two parameters, modified submitChanges to be asynchronous, and removed legacy validation logic and unused imports.
web/core/components/dropdowns/date-range.tsx	Removed the internal state update in the onSelect callback, so the component no longer syncs its internal state with the selected date range.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant DDR as DateRangeDropdown
    participant CS as CycleSidebarHeader
    participant SV as Cycle Service
    
    U->>DDR: Select start & end dates
    DDR->>CS: Trigger onSelect with date range
    CS->>CS: Validate presence of start and end dates (handleDateChange)
    CS->>SV: Await updateCycleDetails(payload)
    SV-->>CS: Return update response

Loading

Possibly related PRs

• [WEB-2903] fix: active cycle update payload #6270: The changes in the main PR focus on restructuring the date selection mechanism and modifying the handling of date parameters, while the retrieved PR addresses the formatting of date values in a payload, indicating that they are related through their shared focus on date handling within the cycle management context.
• [WEB-2380] chore: cycle sidebar refactor #5759: The changes in the main PR regarding the CycleSidebarHeader component's date handling are directly related to the modifications in the retrieved PR, which also involves the date selection mechanism in the sidebar components, specifically transitioning to a DateRangeDropdown.
• [WEB-2106] fix: add date and state change functionalities to list and grid view #5533: The changes in the main PR regarding the DateRangeDropdown and the handling of date selection are directly related to the modifications in the retrieved PR, which also integrates the DateRangeDropdown for selecting date ranges in the ModuleListItemAction component.

Suggested labels

🐛bug, 🌐frontend, 🎨UI / UX

Suggested reviewers

• sriramveeraghanta
• rahulramesha

Poem

I hop through lines of code with delight,
Switching dates from one to range, so bright.
Async steps echo with each new change,
Old validations now out of range.
A bunny celebrates clean, fresh code in flight! 🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fed1b6e and c2a5b7c.

📒 Files selected for processing (2)

• web/core/components/cycles/list/cycle-list-item-action.tsx (2 hunks)
• web/core/components/dropdowns/date-range.tsx (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aaryan610]

Let's make this an optional prop