fix: issue fetch for issue activity task

[pablohashescobar]

Description

add validation check for issue existing in issue activity

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Test Scenarios

• cycle delete and module delete activities for issue

Summary by CodeRabbit

• Bug Fixes
  • Improved system reliability by ensuring that updates occur only on valid records, preventing potential errors when expected data is absent.

[coderabbitai]

Walkthrough

The change updates the condition in the delete_cycle_issue_activity function. Instead of checking if issue is truthy, the function now verifies that current_issue is valid before attempting to update the updated_at field. This ensures that the code only updates the field when a proper Issue object is retrieved, thereby preventing potential errors due to null or non-existent issues. No public API or export declarations were altered.

Changes

File	Change Summary
apiserver/plane/bgtasks/issue_activities_task.py	Modified the condition in delete_cycle_issue_activity to check for current_issue instead of issue before updating the updated_at field

Sequence Diagram(s)

sequenceDiagram
    participant Task as delete_cycle_issue_activity
    participant DB as Database

    Task->>DB: Retrieve current_issue
    alt current_issue exists
        DB-->>Task: Return Issue object
        Task->>DB: Update issue.updated_at field
    else current_issue absent
        DB-->>Task: Return null
        Task->>Task: Skip update
    end

Loading

Suggested labels

🐛bug

Suggested reviewers

• sriramveeraghanta

Poem

Hop, hop, I’m a rabbit so keen,
Fixing bugs in code, neat and clean.
A check for current_issue now leads the way,
Keeping errors at bay each day.
With a twitch of my nose and a joyful hop,
I celebrate this change non-stop!
🐰✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 958a367 and 50533d2.

📒 Files selected for processing (1)

• apiserver/plane/bgtasks/issue_activities_task.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)