Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: russian translation #6666

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

ch4og
Copy link
Contributor

@ch4og ch4og commented Feb 24, 2025

Description

Adds russian translation

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Summary by CodeRabbit

  • New Features
    • Added Russian language support, allowing users to select Russian as their preferred language.
    • Localized translations for Russian are now available, enhancing the international experience.

Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Walkthrough

This pull request adds support for the Russian language across the internationalization system. A new entry for Russian is added to the supported languages constants, the translation store now handles the dynamic import of Russian translations, and the language type definition is updated to include Russian as a valid option.

Changes

File Path Change Summary
packages/i18n/src/constants/language.ts Added a new { label: "Русский", value: "ru" } entry to the SUPPORTED_LANGUAGES array.
packages/i18n/src/store/index.ts Updated the importLanguageFile method to handle Russian ("ru") by adding a new case for dynamic import.
packages/i18n/src/types/language.ts Extended the TLanguage type definition to include the "ru" option.

Sequence Diagram(s)

sequenceDiagram
    participant U as User/Application
    participant TS as TranslationStore
    participant RU as ru/translations.json

    U->>TS: Request load for "ru" language
    TS->>RU: Import Russian translations file
    RU-->>TS: Return Russian translations data
    TS-->>U: Provide Russian translations
Loading

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • anmolsinghbhatia

Poem

I'm just a rabbit, hopping with glee,
Adding Russian support, as easy as can be.
Translations now bloom in a language so true,
With a new "ru" case and code shining through.
🐇💻 Here's to new words in a delightful stew!
Cheers from the burrow, where updates accrue.
Hop on board for more fun!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f70eae2 and 1320408.

📒 Files selected for processing (3)
  • packages/i18n/src/constants/language.ts (1 hunks)
  • packages/i18n/src/store/index.ts (1 hunks)
  • packages/i18n/src/types/language.ts (1 hunks)
🔇 Additional comments (3)
packages/i18n/src/types/language.ts (1)

1-1: LGTM! Type definition updated correctly for Russian language support.

The addition of "ru" to the TLanguage type union is consistent with the existing pattern and properly typed.

packages/i18n/src/constants/language.ts (1)

11-11: LGTM! Russian language option added correctly.

The addition follows the established pattern of using native language names (Русский) and uses the correct language code ("ru").

packages/i18n/src/store/index.ts (1)

150-151:

✅ Verification successful

LGTM! Verify Russian translations file exists.

The implementation follows the established pattern for language imports. However, let's ensure the translations file exists at the specified path.


🏁 Script executed:

#!/bin/bash
# Check if the Russian translations file exists
test -f "packages/i18n/src/locales/ru/translations.json" && echo "✓ Russian translations file exists" || echo "✗ Russian translations file missing"

Length of output: 135


LGTM! Verified that the Russian translations file exists.

The implementation follows the established pattern for language imports correctly, and the file at packages/i18n/src/locales/ru/translations.json was found during verification. No further changes are needed.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

@sriramveeraghanta sriramveeraghanta merged commit 5329326 into makeplane:preview Feb 25, 2025
2 of 3 checks passed
@ch4og ch4og deleted the feat/ru-lang branch February 26, 2025 08:18
@ch4og ch4og mentioned this pull request Feb 26, 2025
1 task
@coderabbitai coderabbitai bot mentioned this pull request Mar 3, 2025
1 task
sriramveeraghanta added a commit that referenced this pull request Mar 5, 2025
* fix: issue activity for project id validation (#6668)

* fix: work item attachment count mutation (#6670)

* updated the action to modify the release build assets (#6669)

* feat: russian translation (#6666)

* chore: ru translation updated (#6672)

* fix: state drop down refactor

* fix: intake work item creation refactor

* fix: cleanup for deprecated functions

* fix: date range picker on cycles and modules list (#6676)

* fix: Handled workspace switcher closing on click

* fix: replaced date range picker with date picker at some places

* chore: add common translation keys (#6688)

* chore: add missing translation keys

* chore: add russian translation keys

* fix: issue activity task (#6689)

* changed github workflow action ubuntu version to `ubuntu-22.04` (#6683)

* chore: update russian translation (#6682)

* chore: update russian translation

* chore: rename issues to work items in russian translation

* [PE-275] chore: editor line spacing variables (#6678)

* chore: variable editor line spacing

* chore: variable list spacing

---------

Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com>

* [WEB-3475] fix: cycle dates dropdown (#6690)

* fix: Handled workspace switcher closing on click

* fix: Cycle date picker

* fix: Made onSelect optional in range range component

* fix: module date picker (#6691)

* fix: Handled workspace switcher closing on click

* fix: reverted module date picker changes

* chore: extended sidebar improvement (#6693)

* feat: italian translations (#6692)

* Create translations.json - ITALIAN translation (#6667)

* chore: italian translation updated

* feat: italian translation added

* fix: module end date translation

---------

Co-authored-by: Nicolas Bossi <nicolasbossi@gmail.com>
Co-authored-by: gakshita <akshitagoyal1516@gmail.com>

* fix: attachment item created by (#6695)

* fix: module flicker issue on property updation (#6699)

* [WEB-3477] fix: mutation issue on moving work items for a manually ended cycle (#6696)

* fix: package version update

* fix: esbuild version fix

* fix: package license repliation

* [WEB-3488] improvement: assignee validation for work item creation (#6701)

* fix: work item assignee update validation (#6704)

---------

Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com>
Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com>
Co-authored-by: Manish Gupta <59428681+mguptahub@users.noreply.github.com>
Co-authored-by: Nikita Mitasov <32384814+ch4og@users.noreply.github.com>
Co-authored-by: Akshita Goyal <36129505+gakshita@users.noreply.github.com>
Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Co-authored-by: Akshat Jain <akshatjain9782@gmail.com>
Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com>
Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com>
Co-authored-by: Nicolas Bossi <nicolasbossi@gmail.com>
Co-authored-by: gakshita <akshitagoyal1516@gmail.com>
Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
@coderabbitai coderabbitai bot mentioned this pull request Mar 6, 2025
1 task
@sriramveeraghanta sriramveeraghanta added this to the v0.25.1 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants