chore: add common translation keys #6688
Conversation
WalkthroughThis pull request updates the localization JSON files for English, Spanish, French, Japanese, Chinese, and Russian. New translation keys have been added for terms including Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
aaryan610
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (7)
packages/i18n/src/locales/en/translations.json (3)
464-465: New Translation Keys for State & Priorities
The keys"state_group": "State group"and"priorities": "Priorities"have been added. Please verify that the singular/plural distinctions and naming conventions are consistent with other locale files.
474-474: Addition of Singular Label Key
The new key"label": "Label"has been introduced alongside the existing plural"labels". Confirm that the intended contexts for singular versus plural use are clearly differentiated in the UI.
480-480: New Translation Key for Estimates (Plural)
The key"estimates": "Estimates"has been added to provide the plural form for estimate-related UI elements. Please ensure that this change is aligned with its singular counterpart"estimate": "Estimate"and that the UI components correctly pick the appropriate term based on context.packages/i18n/src/locales/es/translations.json (1)
646-646: Review: New Key "label"The translation key
"label": "Etiqueta"is now included under the common keys. Ensure that this addition does not conflict with similar keys elsewhere (for instance, in module-specific sections) and that its intended context is clear in the application.packages/i18n/src/locales/ja/translations.json (3)
634-635: Ensure Consistency in Singular vs. Plural for State Group and PrioritiesThe new keys
"state_group": "ステート グループ"and"priorities": "優先度"have been added adjacent to existing keys such as"state_groups": "ステータスグループ". Please verify that the distinction (singular vs. plural) is intentional. If both forms are needed, consider aligning the translations (for example, opting for a consistent format like using either “ステート” or “ステータス”) and ensure that their usage is documented and consistent with other locale files.
644-644: Clarify Singular vs. Plural for Label KeysThe addition of the key
"label": "ラベル"appears immediately after"labels": "ラベル". Confirm that maintaining both a singular and a plural form is required by the application. If they serve distinct roles, a short comment or documentation might help avoid confusion for future maintainers.
652-653: Review New Timestamp Translation KeysThe new keys for timestamps,
"created_at": "クリエイテッド アット"and"completed_at": "コンプリーテッド アット", have been introduced. Verify that these translations adhere to the project’s style guidelines and are consistent with similar keys in other locale files. If a more native phrasing is preferred in Japanese, consider adjusting the translations accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/i18n/src/locales/en/translations.json(2 hunks)packages/i18n/src/locales/es/translations.json(2 hunks)packages/i18n/src/locales/fr/translations.json(2 hunks)packages/i18n/src/locales/ja/translations.json(2 hunks)packages/i18n/src/locales/zh-CN/translations.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (13)
packages/i18n/src/locales/zh-CN/translations.json (2)
634-635: Addition of Singular Translation Keys for State and PrioritiesThe new entries
"state_group": "状态组"and"priorities": "优先级"supplement the existing plural keys. This addition allows the application to reference both singular and plural forms consistently. Please verify that these keys are used as expected across the codebase and align with translations in the other locale files.
644-653: Introducing Singular "label" and Date-Related KeysThe addition of the singular key
"label": "标签"(complementing the existing"labels": "标签") addresses cases where a singular translation is required. Also, the new keys"created_at": "创建于"and"completed_at": "完成于"provide a clear, consistent way to reference time-related labels in the UI. Confirm that these keys match the usage in other locales for uniformity across the project.packages/i18n/src/locales/fr/translations.json (7)
634-634: New Translation Key "state_group" Addition
The addition of"state_group": "Groupe d'état"correctly supplies the singular form for a state group. Ensure that its usage in the application (as opposed to the already existing plural"state_groups") is intentional and consistent.
635-635: New Translation Key "priorities" Addition
The key"priorities": "Priorités"has been added to provide a plural form for priorities. This is consistent with similar keys in other locales.
644-644: New Translation Key "label" Addition
The inclusion of"label": "Étiquette"distinguishes the singular form from the existing"labels": "Étiquettes". Please verify that the application requires both forms to avoid potential confusion.
650-650: New Translation Key "estimates" Addition
The key"estimates": "Estimations"has been added to support the plural display of estimation values. Confirm that any previously duplicated or misplaced keys have been consolidated and that this key is used where expected.
652-652: New Translation Key "created_at" Addition
The key"created_at": "Créé le"accurately reflects a timestamp label for creation. Its addition aligns with similar labels in other locales.
653-653: New Translation Key "completed_at" Addition
The key"completed_at": "Terminé le"is correctly added to denote completion timestamps.
1-2366: Overall JSON Structure and Consistency Check
The file maintains valid JSON structure and the new translation keys are integrated within the "common" section. Please ensure that these additions are harmonized with corresponding keys in other locale files and that the singular versus plural forms are correctly applied throughout the application.packages/i18n/src/locales/en/translations.json (1)
482-483: New Timestamp Translation Keys
The newly added keys"created_at": "Created at"and"completed_at": "Completed at"improve clarity on timestamp labels. Verify that these keys are consistently used across all locales and that any corresponding UI elements accurately reflect these translations.packages/i18n/src/locales/es/translations.json (2)
652-652: Review: New Key "estimates"The new key
"estimates": "Estimaciones"has been added. This plural key should be used consistently throughout the application when referring to multiple estimates. The addition appears correct.
654-655: Review: New Keys "created_at" and "completed_at"The keys
"created_at": "Creado en"and"completed_at": "Completado en"have been added to the translations. These keys are clear and fit well with the typical date/time expressions. Please verify that they align with similar keys (for example,"created_on") used elsewhere in the project.packages/i18n/src/locales/ja/translations.json (1)
650-651: Check Consistency for Estimates KeysThere are near-duplicate keys for estimates:
"estimates": "見積もり"and"estimate": "見積もり". Please ensure that the plural and singular versions are both needed. If they are, checking for consistent usage across different locales is recommended.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/i18n/src/locales/ru/translations.json (1)
632-633: New Keys for Singular Status and Priorities
The keys"state_group": "Группа статусов"and"priorities": "Приоритеты"have been added alongside the existing plural forms ("state_groups": "Группы статусов"and"priority": "Приоритет"). Please verify that the application code distinguishes between singular and plural usage appropriately and that similar updates exist in the other locale files for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/i18n/src/locales/ru/translations.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (3)
packages/i18n/src/locales/ru/translations.json (3)
642-642: Added Singular 'label' Key
The new key"label": "Метка"has been introduced in addition to the existing plural key"labels": "Метки". Ensure that the UI and localization logic correctly choose the singular or plural translation based on context.
648-648: Added Plural 'estimates' Key
The key"estimates": "Оценки"is now available alongside"estimate": "Оценка". Confirm that both forms are used as expected in the codebase and that the plural form is not causing conflicts with previous string references.
650-651: Introduced Time-Related Translation Keys
The new keys"created_at": "Создано в"and"completed_at": "Завершено в"have been added to provide consistent timestamp labeling. Please ensure these keys are now referenced correctly wherever date/timestamp labels are required in the UI. Also, verify consistency with similar keys in other locale files.
* fix: issue activity for project id validation (#6668) * fix: work item attachment count mutation (#6670) * updated the action to modify the release build assets (#6669) * feat: russian translation (#6666) * chore: ru translation updated (#6672) * fix: state drop down refactor * fix: intake work item creation refactor * fix: cleanup for deprecated functions * fix: date range picker on cycles and modules list (#6676) * fix: Handled workspace switcher closing on click * fix: replaced date range picker with date picker at some places * chore: add common translation keys (#6688) * chore: add missing translation keys * chore: add russian translation keys * fix: issue activity task (#6689) * changed github workflow action ubuntu version to `ubuntu-22.04` (#6683) * chore: update russian translation (#6682) * chore: update russian translation * chore: rename issues to work items in russian translation * [PE-275] chore: editor line spacing variables (#6678) * chore: variable editor line spacing * chore: variable list spacing --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * [WEB-3475] fix: cycle dates dropdown (#6690) * fix: Handled workspace switcher closing on click * fix: Cycle date picker * fix: Made onSelect optional in range range component * fix: module date picker (#6691) * fix: Handled workspace switcher closing on click * fix: reverted module date picker changes * chore: extended sidebar improvement (#6693) * feat: italian translations (#6692) * Create translations.json - ITALIAN translation (#6667) * chore: italian translation updated * feat: italian translation added * fix: module end date translation --------- Co-authored-by: Nicolas Bossi <nicolasbossi@gmail.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> * fix: attachment item created by (#6695) * fix: module flicker issue on property updation (#6699) * [WEB-3477] fix: mutation issue on moving work items for a manually ended cycle (#6696) * fix: package version update * fix: esbuild version fix * fix: package license repliation * [WEB-3488] improvement: assignee validation for work item creation (#6701) * fix: work item assignee update validation (#6704) --------- Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: Manish Gupta <59428681+mguptahub@users.noreply.github.com> Co-authored-by: Nikita Mitasov <32384814+ch4og@users.noreply.github.com> Co-authored-by: Akshita Goyal <36129505+gakshita@users.noreply.github.com> Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Co-authored-by: Akshat Jain <akshatjain9782@gmail.com> Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com> Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> Co-authored-by: Nicolas Bossi <nicolasbossi@gmail.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
Description
This PR adds some more common additional keys.
Type of Change
Summary by CodeRabbit
New Features
Refactor