Skip to content

fix(workflows): night-issue-prs merge-blocker drain (open threads + conflicts) - #2046

Merged
natechadwick merged 1 commit into
mainfrom
chore/night-issue-prs-merge-blocker-drain
Aug 5, 2026
Merged

natechadwick merged 1 commit into
mainfrom
chore/night-issue-prs-merge-blocker-drain

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

  • Treat unresolved review threads (human or bot) as merge blockers co-equal with conflicts and failing CI.
  • Anti-starvation: oldest open-blocker PRs first (fixes fix(system): Jackson-migrate content leftovers + PSNodeDefinition (#1921) #1974-style Kilo debt sitting forever).
  • Completeness: finish all threads on a selected PR before moving on.
  • Phase order: PR follow-up PRE then issue Work then PR follow-up POST.
  • Empty triage queue no longer skips PR babysit.
  • Default max_prs 3 to 6 (cap 12); report merge_blockers_still_open.

Context

Operator cannot merge with open review conversations or conflicts. Overnight was conflict-first + max_prs=3, so MERGEABLE PRs with open Kilo threads never cleared.

Test plan

Operator

Grok (model:grok-4.5)

…issue-prs

Human cannot merge PRs with unresolved conversations or conflicts. PR follow-up now drains merge blockers before issue Work (and again after), selects oldest first for anti-starvation, requires completeness on each selected PR, and still runs when the issue queue is empty. Default max_prs is 6 (cap 12).

> Co-Authored by Grok Build using grok-4.5 with agent main.
@natechadwick-intsof natechadwick-intsof added operator:grok Changes authored by Grok model:grok-4.5 Grok 4.5 model labels Aug 5, 2026
@natechadwick
natechadwick merged commit be92219 into main Aug 5, 2026
5 checks passed
@natechadwick
natechadwick deleted the chore/night-issue-prs-merge-blocker-drain branch August 5, 2026 17:05
natechadwick-intsof added a commit that referenced this pull request Sep 6, 2026
* fix(codeql): path-injection #2039–#2044 PSConfigService config files

Contain package config files under RxDir via requireSafeFileName and
requireUnderBase before File.exists / FileInputStream. Parent audit #4348.

> Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security.

* fix(codeql): path-injection #2045 IOTools.getFileContent

Reject NUL paths, open the canonical file, and add getFileContentUnderBase
with requireUnderBase. Parent audit #4348.

> Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security.

* fix(codeql): path-injection #2046–#2050 object-store save files

Contain application save paths under RxDir via requireFileUnderRxDir
before exists/isFile/mkdirs. Parent audit #4348.

> Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security.

* docs(codeql): record path-injection residual alerts #2055–#2057

PR #4349 already has runtime requireUnderBase, sink-line annotations,
query-filters, and tests. CodeQL re-fingerprinted exists() as #2055–#2057
on the PR scan (query-filters do not always filter PR review comments).

> Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs.

* docs(codeql): record path-injection residual alert #2054

PR #4350 already has NUL reject + getCanonicalFile, getFileContentUnderBase,
sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted
FileInputStream as #2054 on the PR scan.

> Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs.

* docs(codeql): record path-injection residual alerts #2058–#2062

PR #4351 already has requireFileUnderRxDir, sink-line annotations,
query-filters, and tests. CodeQL re-fingerprinted save File API as
#2058–#2062 on the PR scan.

> Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs.
natechadwick pushed a commit that referenced this pull request Sep 18, 2026
…4578)

* fix(security): CodeQL #2063–#2075 path-injection residuals (#4577)

Add ObjectStore ApplicationFile store tests under a thread RxDir so
exists/rename/delete stay inside requireUnderBase. Document #2074–#2075
as residual of #2046–#2062. Do not re-edit annotated sinks.

Partial #4577

> Co-Authored by Grok Build 1.0.34 using grok-4.6 with agent night-issue-prs-security.

* fix(security): keep ApplicationFileAdaptor sink line numbers

Drop extra javadoc so CodeQL does not re-fingerprint annotated
exists/move/delete sinks (#2063–#2073).

> Co-Authored by Grok Build 1.0.34 using grok-4.6 with agent night-issue-prs-security.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants