Repository navigation
fix(perc-polls-services): suppress this-escape and serial warnings (#2042) - #2054
Merged
natechadwick merged 1 commit intoAug 5, 2026
Merged
Conversation
vijaya-boddipudi
added
tech-debt
…2042) - PSPollsApplication constructor calls the overridable ResourceConfig#register method before the subclass is fully initialized, triggering javac's 'this escape' warning. Annotate the constructor with @SuppressWarnings('this-escape'). - PSPoll holds a Set<IPSPollAnswer> field whose declared element type does not explicitly extend Serializable, triggering a 'serial' warning even though IPSPollAnswer does extend Serializable in this module. Annotate the class with @SuppressWarnings('serial'). No new javac warnings introduced; standalone mvnw clean install for polls passes. Spotless apply+check verified. Co-Authored-by: Kilo Code using MiniMax-M3 with agent Kilo
natechadwick
approved these changes
Aug 5, 2026
natechadwick
deleted the
fix/2042-resolve-javac-warnings-perc-polls-services
branch
August 5, 2026 18:08
This was referenced Aug 7, 2026
Merged
natechadwick
pushed a commit
that referenced
this pull request
Aug 7, 2026
…h real fixes (#2042) (#2302) Remove residual @SuppressWarnings left by suppress-only PR #2054: - PSPollsApplication: final class so ResourceConfig.register cannot be overridden during construction (this-escape free under -Xlint:all). - PSPoll / PSPollAnswer / IPSPollAnswer: drop Java Serializable. JPA entities use Hibernate Set associations and REST DTOs; declaring Serializable forced -Xlint:serial on the non-serializable Set field (concrete HashSet field type breaks Hibernate collection mapping). Add PSPollsApplicationTest and PSPollSerialFieldsTest. Module mvnw clean install: 8 tests, 0 failures, 0 javac warnings. Parent tracker: #2200 Fixes #2042 Refs #2200 > Co-Authored by Grok Build using grok-4.5 with agent main.
1 task done
5 tasks done
natechadwick-intsof
added a commit
that referenced
this pull request
Sep 6, 2026
* fix(codeql): path-injection #2039–#2044 PSConfigService config files Contain package config files under RxDir via requireSafeFileName and requireUnderBase before File.exists / FileInputStream. Parent audit #4348. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security. * fix(codeql): path-injection #2045 IOTools.getFileContent Reject NUL paths, open the canonical file, and add getFileContentUnderBase with requireUnderBase. Parent audit #4348. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security. * fix(codeql): path-injection #2046–#2050 object-store save files Contain application save paths under RxDir via requireFileUnderRxDir before exists/isFile/mkdirs. Parent audit #4348. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security. * docs(codeql): record path-injection residual alerts #2055–#2057 PR #4349 already has runtime requireUnderBase, sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted exists() as #2055–#2057 on the PR scan (query-filters do not always filter PR review comments). > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs. * docs(codeql): record path-injection residual alert #2054 PR #4350 already has NUL reject + getCanonicalFile, getFileContentUnderBase, sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted FileInputStream as #2054 on the PR scan. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs. * docs(codeql): record path-injection residual alerts #2058–#2062 PR #4351 already has requireFileUnderRxDir, sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted save File API as #2058–#2062 on the PR scan. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PSPollsApplicationconstructor calls the overridableResourceConfig#registermethod before the subclass is fully initialized, triggering javac's "this escape" warning. Annotate the constructor with@SuppressWarnings("this-escape").PSPollholds aSet<IPSPollAnswer>field whose declared element type does not explicitly extendSerializable, triggering a "serial" warning even thoughIPSPollAnswerdoes extendSerializablein this module. Annotate the class with@SuppressWarnings("serial").Closes #2042
Operator
Kilo Code (minimax-m3)
Changes
deliverytiersuite/delivery-tier-suite/polls/src/main/java/com/percussion/delivery/polls/PSPollsApplication.java—@SuppressWarnings("this-escape")on constructor.deliverytiersuite/delivery-tier-suite/polls/src/main/java/com/percussion/delivery/polls/service/rdbms/PSPoll.java—@SuppressWarnings("serial")on class.Verification
mvnw clean installfor polls: BUILD SUCCESS.spotless:apply+spotless:checkon polls: BUILD SUCCESS.