Repository navigation
docs(docker): two-worktree concurrent freeport smoke checklist (#2006) - #2058
Merged
Merged
Conversation
natechadwick-intsof
added
operator:grok
Add operator/agent checklist for multi-worktree freeport cells under docker/README.md (Tier 0 allocation dry-run, Tier 1 CLI dry-run, Tier 2 optional live qa-up/up) with cross-links from workbench-rest-and-qa-modes. Add freeport-concurrent-smoke.py (no Docker/CMS install) proving preferred baseline, second-cell freeport, env override, and tear-down port free via perc_host_ports helpers shared with perc-devctl and matrix-install-smoke. Fixes #2006 Related #2001 #2004 #2005 #2014 > Co-Authored by Grok Build using grok-4.5 with agent main.
Collaborator
Author
|
Overnight follow-up: Rebased onto Ready for review; no unresolved review threads. |
natechadwick-intsof
force-pushed
the
docs/issue-2006-two-worktree-freeport-smoke
branch
from
August 5, 2026 17:40
cf162c6 to
2f4b7a5
Compare
natechadwick
approved these changes
Aug 5, 2026
4 tasks done
1 task done
natechadwick-intsof
added a commit
that referenced
this pull request
Sep 6, 2026
* fix(codeql): path-injection #2039–#2044 PSConfigService config files Contain package config files under RxDir via requireSafeFileName and requireUnderBase before File.exists / FileInputStream. Parent audit #4348. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security. * fix(codeql): path-injection #2045 IOTools.getFileContent Reject NUL paths, open the canonical file, and add getFileContentUnderBase with requireUnderBase. Parent audit #4348. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security. * fix(codeql): path-injection #2046–#2050 object-store save files Contain application save paths under RxDir via requireFileUnderRxDir before exists/isFile/mkdirs. Parent audit #4348. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs-security. * docs(codeql): record path-injection residual alerts #2055–#2057 PR #4349 already has runtime requireUnderBase, sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted exists() as #2055–#2057 on the PR scan (query-filters do not always filter PR review comments). > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs. * docs(codeql): record path-injection residual alert #2054 PR #4350 already has NUL reject + getCanonicalFile, getFileContentUnderBase, sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted FileInputStream as #2054 on the PR scan. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs. * docs(codeql): record path-injection residual alerts #2058–#2062 PR #4351 already has requireFileUnderRxDir, sink-line annotations, query-filters, and tests. CodeQL re-fingerprinted save File API as #2058–#2062 on the PR scan. > Co-Authored by Grok Build 1.0.13 using grok-4.6 with agent night-issue-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents and scripts a two-worktree concurrent freeport smoke checklist so multi-cell stacks do not collide on published host ports.
docker/README.md→ Two-worktree concurrent freeport smoke (docs(docker): two-worktree concurrent smoke checklist for freeport cells #2006):perc-devctlqa-up/up--dry-rundiscovery across two worktreesqa-up/up+ probes + tear-down (notes fixed container names)docs/developer-module/workbench-rest-and-qa-modes.md(QA mode section)docker/scripts/freeport-concurrent-smoke.py+ unit tests — exercises sharedperc_host_ports(preferred → freeport → env override → release)References: parent #2001; freeport slice PR #2003; matrix freeport #2005 / #2014; sibling residual #2004 (DB/compose host ports + still-fixed
container_name).Fixes #2006
Operator: Grok: night-issue-prs (model grok-4.5)
Test plan
python -m pytest docker/scripts/test_freeport_concurrent_smoke.py docker/scripts/test_perc_devctl.py docker/scripts/test_matrix_install_smoke.py -q→ 88 passedpython docker/scripts/freeport-concurrent-smoke.py→RESULT:OK STEP:freeport-concurrent-smokedocker/README.mdGates evidence
pathlibfor scripts dirmvnw.cmd -N spotless:applyfirst, thenspotless:checksecond (BUILD SUCCESS). In-scope only committed (docker/README.md, workbench doc, smoke script + tests). Out-of-scope baseline Spotless rewrites underdocs/ai-generated/code-reviews/*left uncommitted (not folded into this PR)qa-up/up(tracked under #2001 / #2004)Residual
None for #2006 acceptance (checklist + optional dry-run). Parent #2001 still tracks #2004 for remaining compose/DB freeport and worktree-scoped container names.