Repository navigation
docs(1975): inventory Linux CMS Jetty + DTS service scripts (#962 slice 1) - #1985
Merged
Merged
Conversation
…ce 1) Validate issue #1975 path tables against main: dual-ship still present (systemd prefer + --initd); document packaging chains and two packaging gaps (missing CMS defaults/bin/rxjetty.sh after Jetty 12 cleanup; DTS dts-tomcat.service.in not co-located with installDts service scripts). Durable inventory: specs/988-linux-systemd-services/inventory.md Fixes #1975 > Co-Authored by Grok Build using grok-4.5 with agent main.
This was referenced Aug 5, 2026
Closed
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous Review Summary (commit daec4f5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit daec4f5)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Verification performedThis is a docs-only PR. All path and behavioral claims in
Notes
Fix Link: https://app.kilo.ai/cloud-agent-fork/review/394ae93c-81f5-4420-8da3-62d7b37e1d26 Reviewed by ling-3.0-flash:free · Input: 45.7K · Output: 10.5K · Cached: 348.2K Review guidance: REVIEW.md from base branch |
4 of 5 tasks
How to re-validate listed delivery-tier-distribution/... without the deliverytiersuite/delivery-tier-suite/ prefix, unlike CMS paths above. Use full repo-root-relative paths for consistent navigation. > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick
approved these changes
Aug 5, 2026
3 tasks done
This was referenced Aug 29, 2026
natechadwick
pushed a commit
that referenced
this pull request
Aug 29, 2026
* fix(codeql): path-injection #1985 XML JDBC catalog physical path Close CWE-22 on PSXmlDriver.getPhysicalPath / catalogDir File API (alerts #1985/#1986/#1987). resolveUnderAppRoot rejects .. escape; requireUnderBase when the virtual root exists. Sink-line + query-filter. Parent: #2470 Tests: PSVirtualApplicationDirectoryPathInjectionTest, PSFileSystemDriverPathInjectionTest Module: cd system && ../mvnw.cmd clean install (Tests run: 2586, Failures: 0) > Co-Authored by Grok Build 1.0.5 using grok-4.6 with agent night-issue-prs-security. * fix(codeql): sink-line residual #2003-#2007 on XML JDBC catalog Same-line // codeql[java/path-injection] on loc.exists/isDirectory in PSFileSystemDriver.getPhysicalPath (alerts #2003/#2004). Leave already-annotated PSXmlDatabaseMetaData sinks (#2005-#2007) alone. Parent: #2470 Tests: existing PSFileSystemDriverPathInjectionTest Module: cd system && ../mvnw.cmd clean install (Tests run: 2586, Failures: 0) > Co-Authored by Grok Build 1.0.5 using grok-4.6 with agent night-issue-prs.
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates and documents the Linux service install/start/stop inventory for CMS Jetty and DTS (issue #1975 / parent #962 slice 1).
specs/988-linux-systemd-services/inventory.mdplan.md,data-model.md,tasks.md(DTS is in-scope;rxjetty.shpath status)Findings
service/scripts + unit template + README--initd(CMS + DTS)service/defaults/bin/rxjetty.shsystem/Tools/jettyin #662; never restored under perc-jetty) → Gap Adts-tomcat.service.ininstallDts.xmlplaces service scripts underDeployment/Server/.inat product root; scripts look next to\) → Gap BResiduals (product code — not this PR)
defaults/bin/rxjetty.shdts-tomcat.service.inTest plan
maintree (list/grep)src/main/jetty→ assembly → perc-distribution-treejetty/; DTS rootFiles +installDts.xmlmvnw spotless:applythenspotless:check(root); only in-scopespecs/988-*files committedGates evidence
Operator
Operator: Grok: night-issue-prs (model grok-4.5)
Fixes #1975
Partial progress on #962 (inventory only; packaging gaps filed as #1983 #1984)