Repository navigation
fix(#2011): self-contained ant.deps in migration_i18n_locales.xml - #2012
Merged
Merged
Conversation
natechadwick-intsof
added
operator:grok
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 1 Warning, 3 Suggestions | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
Fix link: https://app.kilo.ai/cloud-agent-fork/review/68bd1c79-3d21-4696-8171-18b6e7f5a4fc Previous Review Summaries (2 snapshots, latest commit 1d57b1a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 1d57b1a)Status: 1 Warning, 3 Suggestions | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
Fix link: https://app.kilo.ai/cloud-agent-fork/review/68bd1c79-3d21-4696-8171-18b6e7f5a4fc Previous review (commit a4013bc)Status: 1 Warning, 3 Suggestions | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
Fix link: https://app.kilo.ai/cloud-agent-fork/review/68bd1c79-3d21-4696-8171-18b6e7f5a4fc Reviewed by step-3.7-flash · Input: 62.5K · Output: 11.4K · Cached: 345.6K Review guidance: REVIEW.md from base branch |
natechadwick-intsof
added a commit
that referenced
this pull request
Aug 5, 2026
…back Address PR #2012 review on GH-2011 wiring guards: - assert classpathref and local path id independently (drop dead if/assert) - assert every ant.deps fileset has erroronmissingdir=false - simplify install.chain / upgrade.chain contains checks > Co-Authored by Grok Build using grok-4.5 with agent main.
3 tasks done
Nested <ant inheritRefs> applies parent path refs only after the child project is configured, so project-level taskdef classpathref=ant.deps failed with Reference ant.deps not found and aborted Windows installs. Redefine local path id ant.deps from inherited install.dir/install.src (mirror install.xml JDBC/perc filesets). Extend I18nLocaleMigrationWiringTest to assert local path wiring and install/upgrade chain calls. > Co-Authored by Grok Build using grok-4.5 with agent main.
…back Address PR #2012 review on GH-2011 wiring guards: - assert classpathref and local path id independently (drop dead if/assert) - assert every ant.deps fileset has erroronmissingdir=false - simplify install.chain / upgrade.chain contains checks > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
force-pushed
the
fix/issue-2011-ant-deps-migration
branch
from
August 5, 2026 16:24
1d57b1a to
5dddba5
Compare
Collaborator
Author
|
Overnight follow-up: rebased onto Branch was behind
|
natechadwick
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes full CMS installer abort on Windows when nested
migration_i18n_locales.xmlevaluates project-leveltaskdef classpathref="ant.deps"and fails with Reference ant.deps not found.Root cause: Apache Ant applies parent
inheritRefsonly after the nested project is configured.install.xmlcorrectly definespath id="ant.deps"and calls the migration withinheritAll/inheritRefs=true, but those path refs are not yet visible to project-leveltaskdefin the child.Fix: Self-contained local
<path id="ant.deps">inmigration_i18n_locales.xml, built from inherited${install.dir}/${install.src}(available viainheritAllduring configure). Mirrors the JDBC / perc / extension filesets frominstall.xmlwitherroronmissingdir="false".Test plan
cd modules/perc-distribution-tree && ../../mvnw.cmd clean install— BUILD SUCCESSI18nLocaleMigrationWiringTest— Tests run: 3, Failures: 0, Errors: 0<path id="ant.deps">present; no danglingclasspathrefwithout local pathinstall.chain+upgrade.chainstill invokemigration_i18n_locales.xml(≥2 hits)spotless:applythenspotless:check(in-scope only; monorepo baseline Spotless hits discarded)docs/ai-generated/code-reviews/issue-2011-ant-deps-migration-erlang.mdGates evidence
Operator
Operator: Grok: night-issue-prs (model grok-4.5)
Fixes #2011