Skip to content

[8.2] Resolve javac warnings in perc-system module #2022

Open
5 of 5 issues completed
Open

Description

@vijaya-boddipudi

Description The perc-system module currently completes its build successfully, but still reports Java compiler (javac) and/or Javadoc source warnings that should be cleaned up to improve code quality and maintain a warning-free build. Cleaning these issues will improve API documentation consistency and help maintain overall code quality. Module perc-system Build Summary - Module: perc-system - Build Status: SUCCESS - Reactor Index: 17 - Total Diagnostics: 200 - Javac Warnings: 200 (unique: 200) - Javac Errors: 0 - Javadoc Warnings: 0 - Javadoc Errors: 0 - Analysis Warnings: 0 - Analysis Errors: 0 Expected Result - The module should build without any javac or javadoc warnings or errors. - All source files should compile cleanly under JDK 21 with the project's -Xlint:all settings. - Public classes, interfaces, methods, constructors, fields, and parameters should contain complete and valid Javadoc. Javadoc generation should complete cleanly without warnings. Actual Result The module builds with status SUCCESS, but 200 diagnostic message(s) are reported during compilation. Acceptance Criteria - Resolve all javac and javadoc warnings in the perc-system module. - Ensure all public APIs have complete and valid Javadoc. - Verify the module builds successfully with zero javac errors, zero javadoc errors, and zero javadoc warnings. - Confirm no regressions are introduced during cleanup. Documents to refer and follow: java-api-writing-specs.md javadoc-checklist.md javadoc-spec-summary.md javadoc-tool-architecture.md javadoc-tool-comments.md ## Agent progress (night-issue-prs) | Slice | Issue | Status | PR | Notes | Updated | |-------|-------|--------|----|-------|---------| | extension/webdav/DTD merge Xlint residual (#2944) | #2944 | pr_opened | #2996 | residual of #2935; system 1759 green | 2026-08-11 | | xml/extension/relationship/webdav Xlint (#2935) | #2935 | pr_opened | #2945 | typed xml/extension/relationship/webdav; residual #2944; system clean install 1703 green | 2026-08-11 | | IPSComponent parentComponents residual verify+close (#2455) | #2455 | done | #2952 | main verified List<IPSComponent>; ParentChain tests; zero raw residual; closed | 2026-08-12 | | cms.objectstore parentComponents implementors (#2937) | #2937 | done | #2952 | cms.objectstore typed; merged via cluster #2952 | 2026-08-12 | | IPSComponent parentComponents design.objectstore (#2936) | #2936 | done | #2952 | cascade via cluster #2952 (slices #2936/#2937/#2938); residual #2455 closed after main verify | 2026-08-12 | | remaining parentComponents callers closeout (#2938) | #2938 | done | #2952 | install adapter typed; cascade complete on main via cluster #2952 | 2026-08-12 | | design.objectstore this-escape residual (#2871) | #2871 | pr_opened | #2985 | ~50 leaf finals + parent-list helpers; residual #2984 PSEntry/PSDataSet; system 1703 green | 2026-08-11 | | design.objectstore this-escape PSEntry/PSDataSet (#2984) | #2984 | pr_opened | #2991 | private loadFromXml without parent-list during Element ctor; Application empty+fromXml; PSNullEntry final; system 1756 green | 2026-08-11 | | search exits/index queue rawtypes (#2873) | #2873 | pr_opened | #2997 | residual of #2386; typed exits+index queue; residual Lucene #2998; system 1760 green | 2026-08-11 | | residual search lucene rawtypes (#2998) | #2998 | pr_opened | #3013 | typed indexer/query Map/Collection/List; system 1797 green | 2026-08-11 | | install upgrade-plugin residual after #2942 | #2995 | pr_opened | #3138 | PsxCTTemplate+Relationship+OraConvert+mid plugins; system 1899 green | 2026-08-12 | | server.cache rawtypes (#2877) | #2877 | pr_opened | #3161 | residual of #2299; system 1955 green; residual #3160 | 2026-08-12 | | residual after server.cache (#3160) | #3160 | pr_opened | #3171 | server.webservices typed; system 1956 green; residual #3170 | 2026-08-12 | | residual after server.webservices (#3170) | #3170 | pr_opened | #3187 | session/persist/job/compare typed; residual #3186; system 1965 green | 2026-08-12 | | services.security Xlint (#3181) | #3181 | pr_opened | #3189 | security cluster typed; residual #3188; system 1960 green | 2026-08-12 | | security package Xlint residual (#3182) | #3182 | pr_opened | #3190 | typed security residual + catalog.security; system 1960 green; Fixes #3182 | 2026-08-12 | | services.publisher Xlint (#3188) | #3188 | pr_opened | #3211 | publisher Query/MutationQuery typed; residual #3210; system 1982 green; closed | 2026-08-12 | | services.* Xlint after publisher (#3210) | #3210 | pr_opened | #3266 | contentmgr+legacy typed; residual #3265; system 2008 green; closed | 2026-08-12 | | services.* Xlint after contentmgr/legacy (#3265) | #3265 | pr_opened | #3281 | schedule/workflow/relationship + smaller DAOs typed; residual #3280; system 2068 green | 2026-08-12 | | services.assembly Xlint after #3265 (#3280) | #3280 | pr_opened | #3284 | typed assemblers/nav/jexl maps; system 2073 green | 2026-08-13 | | PSRequest/PSBaseResponse header/cookie/param maps (#3186) | #3186 | pr_opened | #3214 | typed HashMap<String,String>; removed class suppress; residuals #3212/#3213; system 1993 green | 2026-08-12 | | PSApplicationHandler/PSServer dataHandlers residual (#3212) | #3212 | pr_opened | #3267 | typed dataHandlers/request-root maps; residual #3270; system 2007 green | 2026-08-12 | | remaining PSServer init/lock/search Xlint after #3212 (#3270) | #3270 | pr_opened | #3276 | typed init/lock/search leftover; extraParams Map<String,?>; lock maps; system 1952 green; coordinate merge with #3267 | 2026-08-12 | | content/clone/actions command maps residual (#3213) | #3213 | pr_opened | #3271 | typed form/clone/action/command maps; residual #3272 LogDump lists; system 2023 green | 2026-08-12 | | command remaining collections after #3213 (#3272) | #3272 | pr_opened | #3275 | typed LogDump lists + Trace options + FlushCache Iterator; maps left to #3213/#3271; system 2006 green | 2026-08-12 |
| HTTPClient CookieModule + folder processor (#3290) | #3290 | pr_opened | #3293 | typed cookie jar + PSFolderLocatorPaths; system 2112 green; #2299 slice | 2026-08-13 |
| assembly leftover after #3280 (#3291) | #3291 | pr_opened | #3294 | EhCache getObjectType Class<?>; inherent erase leftover documented; system 2108 green | 2026-08-13 |
| security cataloger Xlint residual (#3289) | #3289 | pr_opened | #3296 | PSCatalogerTypes adapters; listed cataloger suppressions cleared; system 2061 green | 2026-08-13 |

Activity

  1. added this to the 8.2 milestone on Aug 5, 2026
  2. removed their assignment
    on Aug 7, 2026
  3. natechadwick-intsof commented on Aug 7, 2026

    @natechadwick-intsof
    Collaborator

    night-issue-prs split (2026-08-07) — disposition split_only for #2022 (perc-system javac).

    Why split

    Issue body reports 200 javac diagnostics. A full worktree sample (mvn -pl system compile, parent -Xlint / -Xlint:-deprecation / -Xlint:serial) with raised -Xmaxwarns 10000 shows ≥10k warning lines (default javac maxwarns is 100, so dashboard/module reports under-count). Too large for one overnight PR under size rules.

    Inventory (kind mix, sample capped at 10k)

    Kind ~Count
    rawtypes 5331
    unchecked 2767
    this-escape 568
    serial + serial-field 581
    removal/deprecation-related 284
    cast / other / varargs ~468

    Hottest packages: design.objectstore, cms.objectstore, data, cms.handlers, data.jdbc, cms, install, search, HTTPClient, security.

    Child slices (unassigned)

    Slice Issue Focus
    1 #2295 rawtypes/unchecked design.objectstore
    2 #2296 rawtypes/unchecked cms.objectstore
    3 #2297 this-escape + serial (objectstore)
    4 #2298 rawtypes/unchecked data + data.jdbc
    5 #2299 remaining packages residual

    Each child targets ≤~40–50 diagnostics per PR; further residuals stay under this epic. Prefer reusing javadoc history #1932 / #1916 without redoing docs-only work. Refs #2200.

    Parent body section ## Agent progress (night-issue-prs) updated with the slice table.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  4. natechadwick-intsof commented on Aug 7, 2026

    @natechadwick-intsof
    Collaborator

    #2295 batch 1 PR opened: #2308

    Co-Authored by Grok Build using grok-4.5 with agent main.

  5. natechadwick-intsof commented on Aug 7, 2026

    @natechadwick-intsof
    Collaborator

    #2296 in progress (2026-08-07)

    Claiming slice 2 (cms.objectstore rawtypes/unchecked). Branch fix/issue-2296-cms-objectstore-rawtypes. Target ≤~40–50 diagnostics on hottest files (PSComponentSummaries / PSRemoteProcessor / PSProcessorCommon / …). Residual remains under #2022.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  6. 144 remaining items

  7. added a commit that references this issue on Aug 13, 2026
  8. natechadwick-intsof commented on Aug 13, 2026

    @natechadwick-intsof
    Collaborator

    2026-08-12: #3265 PR opened #3281 — typed remaining services.* Hibernate queries (schedule/workflow/relationship + smaller DAOs). Residual assembly slice filed as #3280.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  9. natechadwick-intsof commented on Aug 13, 2026

    @natechadwick-intsof
    Collaborator

    night-issue-prs: slice #3280 PR opened: #3284 (assembly/jexl Xlint after #3265). system clean install 2073 tests, 0 failures.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  10. added 2 commits that reference this issue on Aug 13, 2026
  11. natechadwick-intsof commented on Aug 13, 2026

    @natechadwick-intsof
    Collaborator

    night-issue-prs triage: New #2299 children for remaining slice-5 Xlint: #3289 (security catalogers), #3290 (HTTPClient + PSServerFolderProcessor), #3291 (assembly leftover after #3280).

    Co-Authored by Grok Build using grok-4.5 with agent night-issue-prs-triage.

  12. natechadwick-intsof commented on Aug 13, 2026

    @natechadwick-intsof
    Collaborator

    #3290 PR opened: #3293

    Typed CookieModule cookie-jar load + PSFolderLocatorPaths (no unchecked dual-return). system standalone mvnw clean install BUILD SUCCESS (Tests run: 2112, Failures: 0).

    Co-Authored by Grok Build using grok-4.5 with agent main.

  13. natechadwick-intsof commented on Aug 13, 2026

    @natechadwick-intsof
    Collaborator

    Slice #3291 PR opened: #3294 (parent #2299 leftover after #3280/#3284). EhCache getObjectType Class<?> + documented inherent assembly map erase; system 2108 green.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  14. natechadwick-intsof commented on Aug 13, 2026

    @natechadwick-intsof
    Collaborator

    #2299 slice #3289 security cataloger Xlint: PR #3296 opened. system standalone clean install 2061 green.

    Co-Authored by Grok Build using grok-4.5 with agent main.

  15. natechadwick-intsof commented on Sep 3, 2026

    @natechadwick-intsof
    Collaborator

    Reconcile: Agent progress — slice 5 tracker closed.

    Slice Issue Status PR Notes Updated
    5 remaining perc-system Xlint (security/HTTPClient/assembly) #2299 done #3296 #3293 #3294 Closed this reconcile; children #3289–#3291 merged 2026-09-03

    Parent #2022 / umbrella #2200 stay open for any further perc-system or monorepo Xlint inventory.

    Co-Authored by Grok Build 1.0.5 using grok-4.5 with agent night-issue-prs-reconcile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    8.2This issue found in 8.2 releasep8priority 8tech-debttech debt

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions