Repository navigation
fix(perc-system): type remaining assembly/jexl maps (#3280) - #3284
Merged
Merged
Conversation
… casts (#3280) Remove leftover @SuppressWarnings("unchecked") from PSHtmlAssembler, PSMarkdownAssembler, PSBinaryAssembler, PSAssemblyWorkItem.getMetaData, PSNavonNodeInvocationHandler, and PSAssemblerUtils. Introduce PSAssemblyBindingMaps (copy + live $sys view) and typed nav/binary helpers. Fixes #3280 > Co-Authored by Grok Build using grok-4.5 with agent main.
Collaborator
Author
|
qa_deferred_quality — human QA not assigned. This-run PR #3284 (parent #3280) is not a human-QA candidate and does not meet the overnight quality bar. Candidate
Quality bar (live GitHub)
Do not assign @vijaya-boddipudi. Tech-debt typing does not warrant a
|
natechadwick
approved these changes
Aug 13, 2026
This was referenced Aug 13, 2026
natechadwick
pushed a commit
that referenced
this pull request
Aug 13, 2026
…3291) (#3294) Assemblers, workitem getMetaData, and navon copyPropertyMap were typed in #3284. This leftover slice removes FactoryBean rawtypes on PSEhCacheFactoryBean.getObjectType, documents the inherent LiveStringObjectMap erase cast, restores orphaned loadLandingPage javadoc, and adds behavioral Ehcache factory tests. Fixes #3291 Parent: #2299 / #2022 > Co-Authored by Grok Build using grok-4.5 with agent main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-sized residual of #3280 / leftover of #3265 / epic #2022: type remaining
com.percussion.services.assemblyrawtypes/unchecked map usage with real generics.getBindings()casts onPSHtmlAssembler/PSMarkdownAssembler; extractPSBinaryAssemblerSupport.resolveSys(Map<?,?>reads)PSAssemblyWorkItem.getMetaDatauses a live typed$sys.metadataview (PSAssemblyBindingMaps)PSNavHelper.putNavBaseFromVariables+getParams;PSNavonNodeInvocationHandler.copyPropertyMapPSAssemblerUtils.combineusesMap<String, List<String>>; timers use the live$sysviewPSContentFinderBase.findwrites$sys.hasMorethrough the same helperOperator: Grok: night-issue-prs (model grok-4.5)
Parent: #2022
Fixes: #3280
Related leftover of: #3265
Product documentation
Test plan
system/:../mvnw.cmd clean install(JDK 21)../mvnw.cmd "-Dtest=PSAssemblyBindingMapsTest,PSBinaryAssemblerSupportTest,PSNavHelperTypedTest,PSAssemblerUtilsTypedTest,PSServicesPackageTypedTest" testChecklist
systemstandalonemvnw clean installgreensystemstandalone clean install (no skipTests)Gates evidence
systemcd system && ../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 2073, Failures: 0, Errors: 0, Skipped: 241PSAssemblyBindingMapsTest4,PSBinaryAssemblerSupportTest3,PSNavHelperTypedTest3,PSAssemblerUtilsTypedTest4,PSServicesPackageTypedTest8)final/sealed; no public/protected method or ctor signature change. Added new helper types only.