Skip to content

fix(perc-system): type services.contentmgr/legacy Hibernate queries (#3210) - #3266

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-3210-services-contentmgr-legacy
Aug 13, 2026
Merged

natechadwick merged 1 commit into
mainfrom
fix/issue-3210-services-contentmgr-legacy

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

PR-sized residual of #3210 / epic #2022 after publisher batch #3188: type com.percussion.services.legacy and com.percussion.services.contentmgr Hibernate query residual with real generics.

  • PSCmsObjectMgr: replace raw Query / getNamedQuery / native query with createQuery(..., Class), createNamedQuery(..., Class), createNativeQuery(..., Object[].class), and MutationQuery for date updates; bind loadItemEntry with :id
  • PSContentMgr: typed createQuery(..., Object[].class) for id/revision and filter projections
  • PSContentRepository: typed prepareQuery as Query<Map> for new map(...) projections; remove list-level @SuppressWarnings("unchecked"); copy/remap folder id via helpers
  • Tests: PSServicesLegacyTypedTest (7) and PSServicesContentmgrTypedTest (5)

Operator: Grok: night-issue-prs (model grok-4.5)

Parent: #2022
Fixes: #3210
Residual: #3265 (assembly / schedule-workflow / other services)

Product documentation

  • N/A — pure tech-debt generics / no product behavior, UX, API, or operator-step change

Test plan

  1. From system/: ../mvnw.cmd clean install (JDK 21)
  2. Focused: ../mvnw.cmd "-Dtest=PSServicesLegacyTypedTest,PSServicesContentmgrTypedTest" test
  3. Confirm BUILD SUCCESS and new tests green

Checklist

  • Product documentation — N/A (not product-facing): pure tech-debt generics
  • Unit / module tests — 12 new unit tests; system standalone mvnw clean install green
  • WebUI + Playwright — N/A (no WebUI product screen change)
  • Build gates — system standalone clean install (no skipTests)
  • Cross-platform — N/A (no path/file I/O)

Gates evidence

  • modules_built: system
  • build_evidence: cd system && ../mvnw.cmd clean install → BUILD SUCCESS; Tests run: 2008, Failures: 0, Errors: 0, Skipped: 241
  • focused tests: PSServicesLegacyTypedTest 7 + PSServicesContentmgrTypedTest 5 (12 total) green
  • downstream_checked: none — no public type made final/sealed; no public/protected method or ctor signature change. Package-visible HQL helpers added for tests only.
  • C5 UI: N/A (backend tech-debt only)

Partial / residual

Partial for epic #2022 services.* Xlint: remaining packages tracked as #3265.

Co-Authored by Grok Build using grok-4.5 with agent main.

…3210)

Residual of #3188 / epic #2022 after the publisher batch. Type remaining
raw Query/list in PSCmsObjectMgr, PSContentMgr, and PSContentRepository
with createQuery/createNamedQuery/createMutationQuery/createNativeQuery
result classes. Bind loadItemEntry by :id. Add focused unit tests.

> Co-Authored by Grok Build using grok-4.5 with agent main.
@natechadwick
natechadwick merged commit 96c44f4 into main Aug 13, 2026
6 checks passed
@natechadwick
natechadwick deleted the fix/issue-3210-services-contentmgr-legacy branch August 13, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants