[path_provider] Allow getDownloadsPath for Windows #2849

technolion · 2020-06-26T08:21:59Z

Description

The path_provider_plugin for Windows is still in the FDE repository and works well but it misses the getDownloadsPath call on Windows which is already available on macOS.
I created a PR that adds the missing call in flutter-desktop-embedding: google/flutter-desktop-embedding#765
PR 765 has to land first.

This PR is about allowing the call on Windows. Code changes here are trivial, which is why I incremented the version number only on the minor.

Related Issues

flutter/flutter#41715

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

technolion · 2020-07-14T07:58:07Z

@stuartmorgan could I please ask for this to get merged? It's just a very minor change that allows using getDownloadsPath on Windows. So others can make use of this until #41715 gets fixed.

...ges/path_provider/path_provider_platform_interface/lib/src/method_channel_path_provider.dart

* [battery] Fixed typo in README.md (#2944) * [integration_test] Remove debugging statement (#2963) Co-authored-by: Yash Johri <yashjohri1200@gmail.com>

Add README instructions for enablePendingPurchases. If a developer attempts to access this plugin on Android without invoking enablePendingPurchases, an exception is thrown. Related StackOverflow post: https://stackoverflow.com/questions/60046903/flutter-in-app-purchase-enablependingpurchases-enablependingpurchases-must

#2968)

…form side (#2967) * [integration_test] Show stack trace of widget test errors on the platform side We keep things simple for now, because this might change once we have a proper test reporter.

This is the first step in the federation of the plugin.

Co-authored-by: Kifah Meeran <23234883+MaskyS@users.noreply.github.com> Co-authored-by: Aloïs Deniel <alois.deniel@gmail.com> Co-authored-by: Colin Stewart <colin@owlfish.com>

…launch() (#2974)

…launch() (#2979)

* screenshot taking works * squash commits. addressing reviewer comments. making drivercommandmanager->callback manager * addressing reviewer comment. mostly name changes * major rename on all files webdriveraction->webdrivercommand * remove files. use implements * remove timeout. add onScreenshot callback * remove remaning timeouts. add an error message for screenshots. use an object instead of strings for status messages * created a new issue * remove example screenshot saving since it's failing on android. examples in integration_test package is common * changing the version and the change log

Allow running incremental_build.sh on Windows under Git Bash. Longer term this script should be re-written in Dart (#64025), but for now this allows running the script on Windows bots.

* add json config * mv to .ci

This cleans up a number of unnecessary differences in the LICENSE files: - Removes C++ comments ("// ") from the beginnings of all the lines in license files that had them. - Standardizes on having a blank line after the copyright line. - Standardizes on having the final newline in the file. - Standardizes on the indentation of the bulleted conditions. - Standardizes on the locations of line breaks (re-wrapping the text) This makes the license bodies--not including the copyright line--in almost all files the same, and matches the exact formatting already used in flutter/flutter and flutter/engine. The only remaining non-copyright-line differences should now be: - packages/image_picker/image_picker/LICENSE has an extra license - packages/google_sign_in/extension_google_sign_in_as_googleapis_auth/LICENSE use "Google LLC" rather than "Google Inc." in the third condition.

* Implement FlutterPlugin interface on the no-op plugin

@SuppressWarnings

The url_launcher overrides the deprecated shouldOverrideUrlLoading(WebView view, String url) method to be backwards compatible with versions before Android API 24. This however currently displays the warning "WebViewActivity.java uses or overrides a deprecated API." when building for Android. This is causing some problems for developers who treat these warnings as errors as part of their build configuration. This PR addresses this issue by annotating the shouldOverrideUrlLoading(WebView view, String url) method with the @SuppressWarnings("deprecation") attribute. This PR also adds the @RequiresApi(Build.VERSION_CODES.N) annotation to the shouldOverrideUrlLoading(WebView view, WebResourceRequest request) method, which gives the Android/ Java tooling an indication this method should only by used from API 24 and higher.

…p4, possibly others...) (#3007)

…sactions from being completed (#2872) * Fix the bug that prevent restored subscription transactions from being completed * Update changelog * increased version * fixed removing transactions from transactionsSetter * Fixed CHANGELOGS conflicts * transactionsSetter code formating updates * fixed formating

#3010) Fix a typo in a test name and fix quote consistency.

…plugins into pathprovider-windows

googlebot · 2020-09-10T12:46:33Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

technolion · 2020-09-10T13:07:16Z

Googlebot complained:

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors.

I simply rebased my branch with the commits from master that had been added after I created this PR initially. Can someone please explain?

stuartmorgan-g · 2020-09-10T13:51:11Z

I'm not sure how exactly you did your rebasing, but your branch is in a bad state; as you can see, GitHub is showing your PR as changing 208 files.

You'll need to fix your branch and then re-push.

technolion · 2020-09-10T13:54:04Z

Is it necessary to rebase a branch to master at all when providing a PR?

technolion · 2020-09-10T14:11:32Z

I am closing this pull request and create a new one.

gaaclarke · 2020-09-10T17:54:38Z

@technolion fyi you can always use git push -f <remote> to reset a github PR to any hash you want if you want to keep the conversation of a PR but reset the code.

technolion · 2020-09-11T09:49:41Z

The new PR can be found here: #3017

technolion added 2 commits June 26, 2020 09:24

path provider plugin: allow getDownloadsPath for Windows

14bf80b

updated verion and changelog

e6361eb

googlebot added the cla: yes label Jun 26, 2020

technolion mentioned this pull request Jun 26, 2020

[path_provider] Add Windows support flutter/flutter#41715

Closed

fixed formatting problem

e8c3dc8

stuartmorgan-g suggested changes Jul 19, 2020

View reviewed changes

...ges/path_provider/path_provider_platform_interface/lib/src/method_channel_path_provider.dart Outdated Show resolved Hide resolved

jiahaog and others added 23 commits August 26, 2020 06:28

Rebase previous commits (#2966)

f8f666f

* [battery] Fixed typo in README.md (#2944) * [integration_test] Remove debugging statement (#2963) Co-authored-by: Yash Johri <yashjohri1200@gmail.com>

[video_player_platform_interface] fix setMixIWithOthers test channel (

3b6ddc8

#2968)

[video_player] Fix setWithOthers test (#2970)

4a727fa

[integration_test] Show stack trace of widget test errors on the plat…

f8341ef

…form side (#2967) * [integration_test] Show stack trace of widget test errors on the platform side We keep things simple for now, because this might change once we have a proper test reporter.

[integration_test] Fix channel name for iOS, docs (#2972)

e4b55a4

[battery] Moved battery to its own subdir (#2969)

9d1f131

This is the first step in the federation of the plugin.

[integration_test] add support to get timeline (#2947)

e8306b5

[share] Add sharing file support (android & ios) (#970)

c62afee

Co-authored-by: Kifah Meeran <23234883+MaskyS@users.noreply.github.com> Co-authored-by: Aloïs Deniel <alois.deniel@gmail.com> Co-authored-by: Colin Stewart <colin@owlfish.com>

[url_launcher_platform_interface] Add webOnlyWindowName parameter to …

2f33166

…launch() (#2974)

[battery_platform_interface] Introduce package. (#2975)

161aed2

[url_launcher, url_launcher_web]Added webOnlyWindowName parameter to …

7c49361

…launch() (#2979)

[url_launcher, url_launcher_web] Fix API dependencies. (#2984)

b93268e

[google_maps_flutter] Fix Android unit test. (#2985)

90924b5

[google_maps_flutter] Geodesic Polyline support in iOS (#2964)

ae806de

[battery] Port battery to use platform interface (#2980)

854cfd5

Support Windows in incremental_build.sh (#2989)

7027e9d

Allow running incremental_build.sh on Windows under Git Bash. Longer term this script should be re-written in Dart (#64025), but for now this allows running the script on Windows bots.

Add LUCI try builders json config file (#2993)

ee4b263

* add json config * mv to .ci

[flutter_plugin_android_lifecycle] add no-op v2 plugin (#2977)

5d869c4

* Implement FlutterPlugin interface on the no-op plugin

[device_info_platform_interface] Typo in doc fixed (#3006)

8cdb21d

Makapre and others added 8 commits September 9, 2020 13:00

[image_picker_for_web] Safari now can pick more video formats (3gp, m…

0007ce3

…p4, possibly others...) (#3007)

[google_maps_flutter] Fix typo in User Interface example (#3011)

d6fdbbd

[url_launcher_web] Fix a typo in a test name and fix quote consistency (

1ac2978

#3010) Fix a typo in a test name and fix quote consistency.

path provider plugin: allow getDownloadsPath for Windows

adff319

updated verion and changelog

84a2314

fixed formatting problem

1ad4c8d

Merge branch 'pathprovider-windows' of https://github.com/technolion/…

4ed2249

…plugins into pathprovider-windows

technolion requested review from adazh, amirh, bkonyi, bparrishMines, cyanglaz, dnfield, gaaclarke, LHLL, matthew-carroll and mklim as code owners September 10, 2020 12:46

googlebot added cla: no and removed cla: yes labels Sep 10, 2020

removed pre-screening of platform when requesting downlodas path

c33275d

technolion closed this Sep 10, 2020

technolion deleted the pathprovider-windows branch September 10, 2020 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[path_provider] Allow getDownloadsPath for Windows #2849

[path_provider] Allow getDownloadsPath for Windows #2849

Uh oh!

technolion commented Jun 26, 2020

Uh oh!

technolion commented Jul 14, 2020

Uh oh!

Uh oh!

googlebot commented Sep 10, 2020

Uh oh!

technolion commented Sep 10, 2020

Uh oh!

stuartmorgan-g commented Sep 10, 2020

Uh oh!

technolion commented Sep 10, 2020

Uh oh!

technolion commented Sep 10, 2020

Uh oh!

gaaclarke commented Sep 10, 2020

Uh oh!

technolion commented Sep 11, 2020

Uh oh!

Uh oh!

[path_provider] Allow getDownloadsPath for Windows #2849

[path_provider] Allow getDownloadsPath for Windows #2849

Uh oh!

Conversation

technolion commented Jun 26, 2020

Description

Related Issues

Checklist

Breaking Change

Uh oh!

technolion commented Jul 14, 2020

Uh oh!

Uh oh!

googlebot commented Sep 10, 2020

Uh oh!

technolion commented Sep 10, 2020

Uh oh!

stuartmorgan-g commented Sep 10, 2020

Uh oh!

technolion commented Sep 10, 2020

Uh oh!

technolion commented Sep 10, 2020

Uh oh!

gaaclarke commented Sep 10, 2020

Uh oh!

technolion commented Sep 11, 2020

Uh oh!

Uh oh!