Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add README instructions for enablePendingPurchases #2921

Merged
merged 7 commits into from
Aug 26, 2020

Conversation

matthew-carroll
Copy link
Contributor

Add README instructions for enablePendingPurchases.

If a developer attempts to access this plugin on Android without invoking enablePendingPurchases, an exception is thrown.

Related StackOverflow post:
https://stackoverflow.com/questions/60046903/flutter-in-app-purchase-enablependingpurchases-enablependingpurchases-must

Add README instructions for enablePendingPurchases.

If a developer attempts to access this plugin on Android without invoking `enablePendingPurchases`, an exception is thrown.

Related StackOverflow post:
https://stackoverflow.com/questions/60046903/flutter-in-app-purchase-enablependingpurchases-enablependingpurchases-must
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! Could you add version updates in pubspec and CHANGELOG please?

@matthew-carroll
Copy link
Contributor Author

@cyanglaz is there a reason that we would change the version number or the change log for a documentation correction?

@cyanglaz
Copy link
Contributor

I believe the README is only updated on pub when a new version is published

@matthew-carroll
Copy link
Contributor Author

Alright @cyanglaz I went ahead and bumped the version and updated the change log.

@matthew-carroll
Copy link
Contributor Author

Actually, hold up, I need to resolve a conflict.

@matthew-carroll
Copy link
Contributor Author

Now it's updated.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tentatively added some space in the README.

@cyanglaz cyanglaz merged commit 7227263 into master Aug 26, 2020
@cyanglaz cyanglaz deleted the matthew-carroll-patch-1 branch August 26, 2020 15:56
KevinTheGray added a commit to KevinTheGray/plugins that referenced this pull request Aug 31, 2020
* master:
  [url_launcher, url_launcher_web]Added webOnlyWindowName parameter to launch()  (flutter#2979)
  [battery_platform_interface] Introduce package. (flutter#2975)
  [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() (flutter#2974)
  [share] Add sharing file support (android & ios) (flutter#970)
  [integration_test] add support to get timeline (flutter#2947)
  [battery] Moved battery to its own subdir (flutter#2969)
  [integration_test] Fix channel name for iOS, docs (flutter#2972)
  [integration_test] Show stack trace of widget test errors on the platform side (flutter#2967)
  [video_player] Fix `setWithOthers` test (flutter#2970)
  [video_player_platform_interface] fix `setMixIWithOthers` test channel (flutter#2968)
  Add README instructions for enablePendingPurchases (flutter#2921)
  Rebase previous commits (flutter#2966)
  Avoid walleye 26
  Updating documentation to use isEmpty check. (flutter#2955)
  [integration_test] Minor cleanup (flutter#2956)
  [path_provider, video_player] Tweak pubspecs to pass bulk analysis. (flutter#2959)
  [android_intent] fix platform package dep (flutter#2948)
  [shared_preferences_linux] update `file` package dep version to be compatible with framework (flutter#2950)
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Add README instructions for enablePendingPurchases.

If a developer attempts to access this plugin on Android without invoking enablePendingPurchases, an exception is thrown.

Related StackOverflow post:
https://stackoverflow.com/questions/60046903/flutter-in-app-purchase-enablependingpurchases-enablependingpurchases-must
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Add README instructions for enablePendingPurchases.

If a developer attempts to access this plugin on Android without invoking enablePendingPurchases, an exception is thrown.

Related StackOverflow post:
https://stackoverflow.com/questions/60046903/flutter-in-app-purchase-enablependingpurchases-enablependingpurchases-must
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants