This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Updating documentation to use isEmpty check. #2955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to update the version in pubspec.yaml file also. :) |
The value returned is never null. This is already done correclty in the example app.
|
Good catch, thanks! Fixed and force pushed. |
|
@dnfield can you please take a look? Somehow there was no reviewer assigned by default. |
dnfield
approved these changes
Aug 25, 2020
|
@dnfield is it like that even if a PR is failing in just |
|
@yash1200 Correct. Tree has to be green to merge. |
|
Tagged and published. Thanks for catching this! |
KevinTheGray
added a commit
to KevinTheGray/plugins
that referenced
this pull request
Aug 31, 2020
* master: [url_launcher, url_launcher_web]Added webOnlyWindowName parameter to launch() (flutter#2979) [battery_platform_interface] Introduce package. (flutter#2975) [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() (flutter#2974) [share] Add sharing file support (android & ios) (flutter#970) [integration_test] add support to get timeline (flutter#2947) [battery] Moved battery to its own subdir (flutter#2969) [integration_test] Fix channel name for iOS, docs (flutter#2972) [integration_test] Show stack trace of widget test errors on the platform side (flutter#2967) [video_player] Fix `setWithOthers` test (flutter#2970) [video_player_platform_interface] fix `setMixIWithOthers` test channel (flutter#2968) Add README instructions for enablePendingPurchases (flutter#2921) Rebase previous commits (flutter#2966) Avoid walleye 26 Updating documentation to use isEmpty check. (flutter#2955) [integration_test] Minor cleanup (flutter#2956) [path_provider, video_player] Tweak pubspecs to pass bulk analysis. (flutter#2959) [android_intent] fix platform package dep (flutter#2948) [shared_preferences_linux] update `file` package dep version to be compatible with framework (flutter#2950)
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
The value returned is never null. This is already done correclty in the example app. Co-authored-by: Dan Field <dnfield@google.com>
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
The value returned is never null. This is already done correclty in the example app. Co-authored-by: Dan Field <dnfield@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating documentation to be in sync with example. The value returned is never null. This is already done correclty in the
example app.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?