Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() #2974

Merged
merged 4 commits into from
Aug 28, 2020
Merged

[url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() #2974

merged 4 commits into from
Aug 28, 2020

Conversation

balvinderz
Copy link
Contributor

Description

Adds webOnlyWindowName parameter to url_launcher_platform_interface

Related Issues

flutter/flutter#56867

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@balvinderz
Copy link
Contributor Author

@ditman

@balvinderz balvinderz mentioned this pull request Aug 28, 2020
Closed
12 tasks
@ditman ditman changed the title [url_launcher]Web only window name [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() Aug 28, 2020
@ditman ditman self-requested a review August 28, 2020 17:54
ditman
ditman approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the new parameter!

@balvinderz
Copy link
Contributor Author

tests passed @ditman . Can you merge this so i can add the second pr.

@ditman ditman merged commit 2f33166 into flutter:master Aug 28, 2020
@ditman
Copy link
Member

ditman commented Aug 28, 2020

This has been merged, I'll publish it to pub.dev once tests pass in master.

@balvinderz balvinderz deleted the web_only_window_name branch August 28, 2020 19:36
@ditman
Copy link
Member

ditman commented Aug 28, 2020

Tagged and published url_launcher_platform_interface: ^1.0.8

@balvinderz
Copy link
Contributor Author

Thank you . This is the 2nd PR : #2979

@Bilonik
Copy link

Bilonik commented Aug 28, 2020

Cant compile for web getting errors from this platform_interface.

Target dart2js failed: Exception: /root/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.2+1/lib/url_launcher_web.dart:60:16:
Error: The method 'UrlLauncherPlugin.launch' has fewer named arguments than those of overridden method 'UrlLauncherPlatform.launch'.
Future launch(
^
/root/.pub-cache/hosted/pub.dartlang.org/url_launcher_platform_interface-1.0.8/lib/url_launcher_platform_interface.dart:50:16:
Info: This is the overridden method ('launch').
Future launch(

@ditman
Copy link
Member

ditman commented Aug 28, 2020

@Bilonik you're correct, the fix is incoming: #2979

Apologies for the breakage! In the meantime, you may be able to dependency-overrides url_launcher_platform_interface to 1.0.7.

@Bilonik
Copy link

Bilonik commented Aug 28, 2020

@ditman, just reporting the breakage. 🤙

Thanks for the good work!!

4mitabh added a commit to 4mitabh/plugins that referenced this pull request Aug 28, 2020
@4mitabh
Fix breakage PR flutter#2974
7d526a1 
Fixing the launch interface to be compatible with platform changes introduced in 
flutter@2f33166
@ditman
Copy link
Member

ditman commented Aug 28, 2020 •
edited
Loading

The fix for the breakage has been merged to master. I'll publish url_launcher and url_launcher_web as soon as post-submit checks pass. (cc @Bilonik @4mitabh)

@ditman
Copy link
Member

ditman commented Aug 28, 2020 •
edited
Loading

Both url_launcher and url_launcher_web have been published:

If you're seeing trouble like @Bilonik's here, please make sure that you're getting the latest version of the url_launcher package.

KevinTheGray added a commit to KevinTheGray/plugins that referenced this pull request Aug 31, 2020
@KevinTheGray
Merge branch 'master' into kg-connectivity-ios-permissions
c2732ba 
* master:
  [url_launcher, url_launcher_web]Added webOnlyWindowName parameter to launch()  (flutter#2979)
  [battery_platform_interface] Introduce package. (flutter#2975)
  [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() (flutter#2974)
  [share] Add sharing file support (android & ios) (flutter#970)
  [integration_test] add support to get timeline (flutter#2947)
  [battery] Moved battery to its own subdir (flutter#2969)
  [integration_test] Fix channel name for iOS, docs (flutter#2972)
  [integration_test] Show stack trace of widget test errors on the platform side (flutter#2967)
  [video_player] Fix `setWithOthers` test (flutter#2970)
  [video_player_platform_interface] fix `setMixIWithOthers` test channel (flutter#2968)
  Add README instructions for enablePendingPurchases (flutter#2921)
  Rebase previous commits (flutter#2966)
  Avoid walleye 26
  Updating documentation to use isEmpty check. (flutter#2955)
  [integration_test] Minor cleanup (flutter#2956)
  [path_provider, video_player] Tweak pubspecs to pass bulk analysis. (flutter#2959)
  [android_intent] fix platform package dep (flutter#2948)
  [shared_preferences_linux] update `file` package dep version to be compatible with framework (flutter#2950)
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@balvinderz @jorgefspereira
[url_launcher_platform_interface] Add webOnlyWindowName parameter to …
09003b8 
…launch() (flutter#2974)
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@balvinderz
[url_launcher_platform_interface] Add webOnlyWindowName parameter to …
39a2174 
…launch() (flutter#2974)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balvinderz @ditman @Bilonik @googlebot