Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add LUCI try builders json config file #2993

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

keyonghan
Copy link
Contributor

Description

This is to support plugins repo LUCI try builders, triggered by cocoon backend.

To be consistent with other repos like flutter/flutter, flutter/engine, flutter/cocoon, etc. we put the config file under /dev. The json format will be validated from plugins/plugins.py recipe.

Related Issues

flutter/flutter#56143 (comment)

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's ask @stuartmorgan it is ok to add the files in this location.

@stuartmorgan-g
Copy link
Contributor

LGTM but let's ask @stuartmorgan it is ok to add the files in this location.

I'm not the best authority for the flutter/plugins repo, but given that there's already a .ci folder at the top level is there any reason not to just use that?

(Also, dev seems like a potentially confusing name given that it's the name of a Flutter channel.)

@stuartmorgan-g
Copy link
Contributor

Oh, I just saw this part:

To be consistent with other repos like flutter/flutter, flutter/engine, flutter/cocoon, etc. we put the config file under /dev.

flutter/flutter already had a dev/ folder containing CI stuff, and flutter/engine doesn't have a dev/ folder that I can see, so the consistency argument seems questionable. I think using the existing folder that this repo uses for CI would be better.

@keyonghan
Copy link
Contributor Author

Oh, I just saw this part:

To be consistent with other repos like flutter/flutter, flutter/engine, flutter/cocoon, etc. we put the config file under /dev.

flutter/flutter already had a dev/ folder containing CI stuff, and flutter/engine doesn't have a dev/ folder that I can see, so the consistency argument seems questionable. I think using the existing folder that this repo uses for CI would be better.

Yeah, you are right. flutter, cocoon, and packages are all with dev, whereas engine is a special case with ci/dev. Sure. We can do the same for plugins similar to engine.

As for consistency, I meant to say all are with dev/builders.json. Sorry for the confusion.

@keyonghan keyonghan merged commit ee4b263 into flutter:master Sep 3, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants