Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher, url_launcher_web] Fix API dependencies. #2984

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

ditman
Copy link
Member

@ditman ditman commented Aug 31, 2020

Description

The latest changes to the url_launcher added a new web-only parameter to the platform interface API. However, it didn't update the dependencies of the other url_launcher packages to the right version of the platform interface.

In cases where the app has previously resolved some of its dependencies (pubspec.lock is present), pub might not download the latest versions of all packages, causing errors with this new parameter being added.

This PR addresses the issue by bumping the minimal versions of the packages that fulfill the correct APIs, bringing everything up to speed.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ditman ditman requested a review from stuartmorgan-g August 31, 2020 18:31
@ditman ditman self-assigned this Aug 31, 2020
@ditman
Copy link
Member Author

ditman commented Aug 31, 2020

(When publishing this, I'll publish web first, then the core package)

@ditman ditman merged commit b93268e into flutter:master Aug 31, 2020
@ditman ditman deleted the bump-url-launcher-deps branch August 31, 2020 19:22
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants