This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Support Windows in incremental_build.sh #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow running incremental_build.sh on Windows under Git Bash. Longer term this script should be re-written in Dart (#64025), but for now this allows running the script on Windows bots.
dnfield
reviewed
Sep 1, 2020
Comment on lines
+9
to
+13
| if [ "$(expr substr $(uname -s) 1 5)" == "MINGW" ]; then | ||
| PUB=pub.bat | ||
| else | ||
| PUB=pub | ||
| fi |
There was a problem hiding this comment.
Could the if here just be command -v pub.bat?
There was a problem hiding this comment.
What's the advantage of that approach? If for some reason there were an executable called pub.bat in the path on Linux or macOS we wouldn't want to run it, and if pub.bat isn't there on Windows pub still wouldn't be the right command to try to run, so it seems like an odd construction to me.
There was a problem hiding this comment.
I'm worried if the Windows image changes this will break. But that should be covered by CI. LGTM.
There was a problem hiding this comment.
Hopefully we'll rewrite it in Dart before then :)
There was a problem hiding this comment.
You are much more optimistic than I am :D
dnfield
approved these changes
Sep 1, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
Allow running incremental_build.sh on Windows under Git Bash. Longer term this script should be re-written in Dart (#64025), but for now this allows running the script on Windows bots.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Allow running incremental_build.sh on Windows under Git Bash. Longer term this script should be re-written in Dart (#64025), but for now this allows running the script on Windows bots.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow running incremental_build.sh on Windows under Git Bash. Longer
term this script should be re-written in Dart (#64025), but for now this
allows running the script on Windows bots.
Related Issues
flutter/flutter#56143
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?