Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker_for_web] Can't select some video file types (3gp, mp4, possibly others...) #3007

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Conversation

Makapre
Copy link
Contributor

@Makapre Makapre commented Sep 7, 2020

Description

This PR attempts #58532 and solves video selecting issues when using the image_picker plugin in safari. This issue comes from the webkit and apples own MIMETypes. (see)
Following video file types can be selected(others not tested):

  • .mp4
  • .3gp
  • .avi
  • .mov

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, modify the pubspec.yaml and the CHANGELOG.md so we can publish this change to pub.dev.

@Makapre
Copy link
Contributor Author

Makapre commented Sep 8, 2020

Latest commit updates pubspec.yml and CHANGELOG.md.

@ditman ditman self-requested a review September 8, 2020 19:29
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution. Let's wait for the CI to finish in order to merge this.

@ditman ditman merged commit 0007ce3 into flutter:master Sep 9, 2020
@Makapre Makapre deleted the issue_58532 branch September 9, 2020 20:14
@ditman
Copy link
Member

ditman commented Sep 9, 2020

Merged and published! Thanks @Makapre!

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[image_picker_for_web] Can't select some video file types (3gp, mp4, possibly others...)
3 participants