Allow configurable # of legend colors but default to 4 #25400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
When generating a plugin with the plugin generator and scss is in use, we should add the generated `app.css` file to the .gitignore file.
* Add a note about index migrations to the kibana setup docs * Tewak the migrations asciidocs for clarity * docs: refine saved object migration details Breaking down the migration process into sections helps people find and link to relevant information more easily. The focus is on ongoing maintenance of Kibana, whereas the initial new experience in 6.5.0 is treated as a note of clarification. Error handling should be expanded in the future to include details about specific known error cases.
* Translate monitoring -> summary_status, table, main.html in directives * Fix issues * Fix tests * Add disable eslint for unused var intl
* Create common routines for PDF and PNG report processing * REmove Blacklisted headers not needed * Changes for issues with PDF and PNG testing As per Joel Griffith suggestion I added removal of toast notifications after each click download report. And removed setting of image density to 300. * removed uneccesary image compare routine * Moved server from property on job to passed in parameter. * consolidated PDF and PNG testing Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions. * Typescripted the common functions and broke out tests to individual test files * Create a common create mock server function that all new tests call * Removed unnecessary exception check and removed test include from index.ts
* Add href option in addition to onClick * Small modificationd and adding tests * Add missing import * Switch order of tests * Don't close panel menu again
* Translate monitoring -> license * Translate monitoring -> page_loading * Translate monitoring -> no_data * Fix issues * Update unit tests * Fix eslint
Fixes elastic#16483, Fixes elastic#20115, Fixes elastic#17852, Fixes elastic#16768, Fixes elastic#14348, Fixes elastic#17842, closes elastic#15580, closes elastic#14938
* fix: switch to new CustomEvent new Event is not supported in IE11 * fix: skip element.scrollTo when not available that method doesn't exist on elements in IE11
…elastic#25662) This reverts commit f10deb1.
…methods (elastic#25611) * [ui/chrome] add stub type def for `setRootController()` * [chrome/types] add types for theme related chrome methods
* fix status.allowAnonymous * address PR feedback
* [DOCS] Adds Release Notes for 7.0.0-alpha1 * [DOCS] Incorporated review comments into 7.0.0-alpha1 release notes * [DOCS] Updated text about K7 design
* feat(NA): remove husky dependency and implement a git hooks registering mechanism. * fix(NA): apply executable chmod to the created kbn git hook script. * fix(NA): run npm script on the git pre commit hook silently. * refact(NA): apply changes according the PR review. * refact(NA): apply changes according PR review.
* Translate Spaces component * fix one little error * update Spaces component * update translation of Spaces components * Update snapshots * update Space translation - intl type * update Space translation - remove view/views id namespace * rename ids * use testing helper functions instead of shallow, render, mount from enzyme * fix unit tests * fix ts path for enzyme test helpers * fix path to enzyme helpers test functions * Update snapshots * fix path to enzyme test helpers * Remove unused dependency.
…lastic#25645) * [ML] Fix getDerivedStateFromProps in preparation for React upgrade. * [ML] Fix test by using mount() instead of shallow().
* Translate monitoring - access_denied * Translate monitoring - lib, services * Translate monitoring - common * Fix issues * Fix issue
Coverts ML's Less files to Sass and introduces EUI variables.
This changes the header to be conditionally rendered based on the k7design UI setting. If the setting is false, the header is rendered as before. If it is true, the header is hidden and the breadcrumbs are set via the Kibana breadcrumbs api.
* Update guideline * Fix code review comments
* adds global, workpad css styling feature * fixes checkered position and default CSS in textarea * adds global, workpad css styling feature * fixes checkered position and default CSS in textarea * Added global styles to page manager * Added 'apply stylesheet' button * fix after rebase * change style to css * move default workpad CSS class to constant * unwind the empty page color pieces
* Fix scrolling list on Firefox * Update jest snapshost after adding a class to modal
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
…well/kibana into enh/modifiableNumLegendColors
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
oop, the diff is a little wonky. maybe an issue with a merge (?)
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
@thomasneirynck Yeah, I accidentally did a much later rebase instead of a merge so the diff looks terrible but is actually fine. The failures (up until this last one) were related to an issue where jenkins doesn't "see" any updates to the code and therefore doesn't run the build, it throws a |
This comment has been minimized.
This comment has been minimized.
Contributor
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
56 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the getLegendColors function to accept an argument to increase or decrease the number of colors represented. Default is still 4.