[i18n] Update guideline #25098
Merged
[i18n] Update guideline #25098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-lapata
requested review from
LeanidShutau,
Nox911,
pavel06081991 and
tibmt
Contributor
💚 Build Succeeded |
azasypkin
approved these changes
Nov 6, 2018
Member
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
LGTM, just a bunch of suggestions and nits in addition to what @pavel06081991 has already left.
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Dec 3, 2018
* Update guideline * Fix code review comments
maryia-lapata
added a commit
that referenced
this pull request
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update i18n guideline