Skip to content

Conversation

@legrego
Copy link
Member

@legrego legrego commented Nov 30, 2018

Summary

This PR updates the GET /api/security/role endpoint to return the list of roles sorted by their name, instead of the ES default of creation date.

Fixes #18236

@legrego legrego added release_note:fix Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// labels Nov 30, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego requested a review from kobelb December 3, 2018 13:30
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this being sorted at the API level since this is a public API, but if we want to ensure the sorting in specific places in the UI it feels like we should be doing explicit sorting there.

@legrego
Copy link
Member Author

legrego commented Dec 3, 2018

I'm fine with this being sorted at the API level since this is a public API, but if we want to ensure the sorting in specific places in the UI it feels like we should be doing explicit sorting there.

I was torn on this as well...on one hand, I like that the sort logic is in one place, so that consumers don't have to worry about it, and we get a consistent experience "for free", but OTOH, the display logic is less explicit, and figuring out why the sort is a particular way requires more digging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:enhancement Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v6.6.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants