Fix redirect after logging in #25546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
Team:Security
Contributor
|
Pinging @elastic/kibana-security |
Contributor
💚 Build Succeeded |
Member
Author
|
@kobelb to confirm, this isn't something we want in 6.5.0, right? I should target this for 6.5.1? |
Contributor
|
Yeah. 6.5.1 seems appropriate, I don’t think we should be blocking the release on this.
…________________________________
From: Larry Gregory <notifications@github.com>
Sent: Tuesday, November 13, 2018 4:47:48 AM
To: elastic/kibana
Cc: Brandon Kobel; Mention
Subject: Re: [elastic/kibana] Fix redirect after logging in (#25546)
@kobelb<https://github.com/kobelb> to confirm, this isn't something we want in 6.5.0, right? I should target this for 6.5.1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#25546 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAmRswkJaoC25iDaD3ElYEybtunTJ_01ks5uur90gaJpZM4YaIo_>.
|
legrego
force-pushed
the
spaces/fix-login-redirect
branch
from
cbba5f6 to
5c0e6b4
Compare
Contributor
💚 Build Succeeded |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Nov 14, 2018
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Nov 14, 2018
legrego
added a commit
that referenced
this pull request
Nov 26, 2018
legrego
added a commit
that referenced
this pull request
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the login redirection "space aware". Previously, the
nextparameter was derived from theserver.basePathconfiguration option, instead of the space-awarerequest.getBasePath()function.Fixes #25544