Fix scrolling list on Firefox #26246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
v7.0.0
Team:Visualizations
Contributor
💔 Build Failed |
Member
Author
|
Legit failure. Missing updating test snapshots. |
Contributor
💚 Build Succeeded |
timroes
approved these changes
Nov 28, 2018
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Code looks as good as it can while dealing with CSS issues to me :-) Tested in Firefox, fixed the behavior.
markov00
force-pushed
the
fix/new_viz_modal_scroll_ff
branch
from
4c98baa to
98d7727
Compare
markov00
force-pushed
the
fix/new_viz_modal_scroll_ff
branch
from
98d7727 to
f4ba812
Compare
Contributor
💚 Build Succeeded |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Dec 3, 2018
* Fix scrolling list on Firefox * Update jest snapshost after adding a class to modal
markov00
added a commit
that referenced
this pull request
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #26209
The issue is related to the requirement of having
min-height: 0on the content wrapper div es explained https://moduscreate.com/blog/how-to-fix-overflow-issues-in-css-flex-layouts/ or https://bugzilla.mozilla.org/show_bug.cgi?id=1176723Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately