Feature/translate monitoring access denied #24985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
maryia-lapata
approved these changes
Nov 1, 2018
x-pack/plugins/monitoring/public/views/access_denied/index.html
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
chrisronline
reviewed
Nov 5, 2018
|
|
||
| // generate Elasticsearch breadcrumbs | ||
| function getElasticsearchBreadcrumbs(mainInstance) { | ||
| const esLabel = i18n.translate('xpack.monitoring.breadcrumbs.esLabel', { defaultMessage: 'Elasticsearch' }); |
Contributor
There was a problem hiding this comment.
I'm still not clear on this. Are we translating Elasticsearch or not?
Contributor
Author
There was a problem hiding this comment.
Thanks. No, we don't translate this label.
chrisronline
approved these changes
Nov 5, 2018
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
LGTM, just one outstanding question!
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 15, 2018
* Translate monitoring - access_denied * Translate monitoring - lib, services * Translate monitoring - common * Fix issues * Fix issue
maryia-lapata
added a commit
that referenced
this pull request
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate:
monitoring -> public -> view -> access_denied,
monitoring -> public -> services,
monitoring -> public -> lib,
monitoring ->common,
Fixes: #24713