Translate Spaces component #24411

tibmt · 2018-10-23T15:32:18Z

Translation of Spaces component

elasticmachine · 2018-10-23T16:10:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-24T08:45:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

tibmt · 2018-10-24T08:57:11Z

retest

elasticmachine · 2018-10-24T09:12:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

pavel06081991 · 2018-10-24T12:03:16Z

x-pack/plugins/spaces/public/components/manage_spaces_button.tsx

      >
-        Manage spaces
+        <FormattedMessage
+          id="xpack.spaces.managementSpacesButton.manageSpacesButton"


managementSpacesButton => manageSpacesButton
manageSpacesButton => manageSpacesButtonLabel

pavel06081991 · 2018-10-24T12:04:41Z

x-pack/plugins/spaces/public/lib/spaces_manager.ts

    toastNotifications.addDanger({
-      title: 'Unable to change your Space',
-      text: 'please try again later',
+      title: i18n.translate('xpack.spaces.lib.spacesManagement.unableChangeSpaceTitle', {


please be more attentive. spacesManagement => spacesManager
unableChangeSpaceTitle => unableToChangeSpaceWarningTitle

pavel06081991 · 2018-10-24T12:06:01Z

x-pack/plugins/spaces/public/lib/spaces_manager.ts

+      title: i18n.translate('xpack.spaces.lib.spacesManagement.unableChangeSpaceTitle', {
+        defaultMessage: 'Unable to change your Space',
+      }),
+      text: i18n.translate('xpack.spaces.lib.spacesManagement.retryChangeLaterTitle', {


spacesManagement => spacesManager
retryChangeLaterTitle => unableToChangeSpaceWarningDescription

pavel06081991 · 2018-10-24T12:20:01Z

x-pack/plugins/spaces/public/views/management/components/confirm_delete_modal.tsx

 }

-export class ConfirmDeleteModal extends Component<Props, State> {
+export class ConfirmDeleteModalUI extends Component<Props, State> {


remove export

pavel06081991 · 2018-10-24T12:21:45Z

x-pack/plugins/spaces/public/views/management/components/confirm_delete_modal.tsx

-            You are about to delete your current space {name}. You will be redirected to choose a
-            different space if you continue.
+            <FormattedMessage
+              id="xpack.spaces.view.management.confirmDeleteButton.redirectTitle"


confirmDeleteButton => confirmDeleteModal

elasticmachine · 2018-10-24T14:16:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

pavel06081991 · 2018-10-24T14:05:47Z

...public/views/management/components/advanced_settings_subtitle/advanced_settings_subtitle.tsx

-          The settings on this page apply to the <strong>{props.space.name}</strong> space, unless
-          otherwise specified.
+          <FormattedMessage
+            id="xpack.spaces.view.management.advancedSettingsSubtitle.settingsOnThisPageTitle"


{message} => {spaceName}
settingsOnThisPageTitle => applyingSettingsOnPageToSpaceDescription

pavel06081991 · 2018-10-24T14:07:00Z

x-pack/plugins/spaces/public/views/management/components/confirm_delete_modal.tsx

-            You are about to delete your current space {name}. You will be redirected to choose a
-            different space if you continue.
+            <FormattedMessage
+              id="xpack.spaces.view.management.confirmDeleteModal.redirectTitle"


redirectTitle => redirectAfterDeletingCurrentSpaceWarningMessage

pavel06081991 · 2018-10-24T14:07:35Z

x-pack/plugins/spaces/public/views/management/components/confirm_delete_modal.tsx

            <EuiModalHeaderTitle data-test-subj="confirmModalTitleText">
-              Delete space {`'${space.name}'`}
+              <FormattedMessage
+                id="xpack.spaces.view.management.confirmDeleteModal.confirmDeletingButtonLabel"


confirmDeletingButtonLabel => confirmDeleteSpaceButtonLabel

pavel06081991 · 2018-10-24T14:08:20Z

x-pack/plugins/spaces/public/views/management/components/confirm_delete_modal.tsx

-                Deleting a space permanently removes the space and{' '}
-                <strong>all of its contents</strong>. You can't undo this action.
+                <FormattedMessage
+                  id="xpack.spaces.view.management.confirmDeleteModal.permanentlyRemovingAllSpacesTitle"


permanentlyRemovingAllSpacesTitle => deletingSpaceWarningMessage

pavel06081991 · 2018-10-24T14:09:00Z

x-pack/plugins/spaces/public/views/management/components/confirm_delete_modal.tsx

+                    allContents: (
+                      <strong>
+                        <FormattedMessage
+                          id="xpack.spaces.view.management.confirmDeleteModal.allContentsTitle"


allContentsTitle => allContentsText

pavel06081991 · 2018-10-24T15:01:30Z

x-pack/plugins/spaces/public/views/management/spaces_grid/spaces_grid_page.tsx

+              id: 'xpack.spaces.view.management.spacesGrid.spacesGridPage.deleteNameTitle',
+              defaultMessage: 'Delete',
+            }),
+            description: intl.formatMessage({


pavel06081991 · 2018-10-24T15:03:05Z

x-pack/plugins/spaces/public/views/nav_control/components/spaces_menu.tsx

-          no spaces found{' '}
+          <FormattedMessage
+            id="xpack.spaces.view.navControl.spacesMenu.noSpacesFoundTitle"
+            defaultMessage=" no spaces found "


Please check that spaces you added around no spaces found are displayed. If no, use {' '} like it was done before

@tibmt Has this been checked?

pavel06081991 · 2018-10-24T15:04:10Z

x-pack/plugins/spaces/public/views/space_selector/space_selector.tsx

-                  <p>You can change your space at anytime.</p>
+                  <p>
+                    <FormattedMessage
+                      id="xpack.spaces.view.spaceSelector.spaceSelector.youCanChangeSpaceAnytimeTitle"


youCanChangeSpaceAnytimeTitle => changingSpaceDescription

pavel06081991 · 2018-10-24T15:04:41Z

x-pack/plugins/spaces/public/views/space_selector/space_selector.tsx

                >
-                  No spaces match search criteria
+                  <FormattedMessage
+                    id="xpack.spaces.view.spaceSelector.spaceSelector.noSpacesMatchSearchTitle"


noSpacesMatchSearchTitle => noSpacesMatchSearchCriteriaDescription

pavel06081991 · 2018-10-24T15:05:10Z

x-pack/plugins/spaces/public/views/space_selector/space_selector.tsx

          className="spaceSelector__searchField"
-          placeholder="Find a space"
+          placeholder={intl.formatMessage({
+            id: 'xpack.spaces.view.spaceSelector.spaceSelector.findSpaceTitle',


again. it is placeholder, not title.
findSpaceTitle => findSpacePlaceholder

elasticmachine · 2018-10-25T12:23:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-26T10:12:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-26T15:25:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-26T16:30:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

tibmt · 2018-10-29T07:38:53Z

this PR is blocked by #24527

…nzyme

elasticmachine · 2018-11-06T15:47:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-08T10:57:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-08T14:04:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-08T14:55:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

pavel06081991 · 2018-11-08T15:07:06Z

retest

elasticmachine · 2018-11-08T15:36:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

joshdover

LGTM, just checking in on a couple of the comments Pavel left.

joshdover · 2018-11-08T16:44:47Z

x-pack/plugins/spaces/public/views/management/spaces_grid/spaces_grid_page.tsx

          {
-            name: 'Edit',
-            description: 'Edit this space.',
+            name: intl.formatMessage({


Looks like this and the two below still need to be updated?

joshdover · 2018-11-08T16:46:03Z

x-pack/plugins/spaces/public/views/nav_control/components/spaces_menu.tsx

-          no spaces found{' '}
+          <FormattedMessage
+            id="xpack.spaces.view.navControl.spacesMenu.noSpacesFoundTitle"
+            defaultMessage=" no spaces found "


@tibmt Has this been checked?

elasticmachine · 2018-11-08T17:54:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-08T18:25:20Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-09T10:52:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-13T12:50:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-13T15:41:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-14T09:47:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Translate Spaces component * fix one little error * update Spaces component * update translation of Spaces components * Update snapshots * update Space translation - intl type * update Space translation - remove view/views id namespace * rename ids * use testing helper functions instead of shallow, render, mount from enzyme * fix unit tests * fix ts path for enzyme test helpers * fix path to enzyme helpers test functions * Update snapshots * fix path to enzyme test helpers * Remove unused dependency.

elasticmachine · 2018-11-15T12:45:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

Translate Spaces component

83e1e47

tibmt added the Project:i18n label Oct 23, 2018

tibmt self-assigned this Oct 23, 2018

tibmt requested a review from pavel06081991 October 23, 2018 15:32

maryia-lapata added the v6.6.0 label Oct 24, 2018

tibmt added 2 commits October 24, 2018 11:40

fix one little error

7adf57c

Merge branch 'master' into feature/translations/spaces

de11dc3

pavel06081991 reviewed Oct 24, 2018

View reviewed changes

update Spaces component

e9f8f54

pavel06081991 reviewed Oct 24, 2018

View reviewed changes

tibmt added 2 commits October 25, 2018 12:49

update translation of Spaces components

c683d5f

Merge branch 'master' into feature/translations/spaces

142f6df

Update snapshots

2f2ec23

tibmt added 3 commits October 26, 2018 16:13

update Space translation - intl type

a17f9e5

update Space translation - remove view/views id namespace

dd0d569

Merge branch 'master' into feature/translations/spaces

8df3e18

pavel06081991 added the blocked label Oct 29, 2018

pavel06081991 added 3 commits November 1, 2018 17:16

Merge branch 'master' into feature/translations/spaces

7a1c1f9

rename ids

8eaa742

use testing helper functions instead of shallow, render, mount from e…

114c357

…nzyme

pavel06081991 added 2 commits November 8, 2018 11:47

fix ts path for enzyme test helpers

ae492f7

Merge branch 'master' into feature/translations/spaces

6c3c66e

fix path to enzyme helpers test functions

e3aaa91

Update snapshots

e1e15b7

pavel06081991 added 2 commits November 8, 2018 18:42

fix path to enzyme test helpers

51c81fe

Merge branch 'master' into feature/translations/spaces

2496e6e

joshdover approved these changes Nov 8, 2018

View reviewed changes

Merge branch 'master' into feature/translations/spaces

37d2058

Merge branch 'master' into feature/translations/spaces

9bc5762

Remove unused dependency.

da0c882

Merge branch 'master' into feature/translations/spaces

150f99f

Merge branch 'master' into feature/translations/spaces

bbce5c7

maryia-lapata merged commit fb6be4c into elastic:master Nov 15, 2018

maryia-lapata mentioned this pull request Nov 15, 2018

[6.x] Translate Spaces component (#24411) #25696

Merged

maryia-lapata added the backported label Nov 15, 2018

Translate Spaces component #24411

Translate Spaces component #24411

Uh oh!

Conversation

tibmt commented Oct 23, 2018 • edited by maryia-lapata Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Oct 23, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 24, 2018

💔 Build Failed

Uh oh!

tibmt commented Oct 24, 2018

Uh oh!

elasticmachine commented Oct 24, 2018

💔 Build Failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 24, 2018

💔 Build Failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 25, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 26, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 26, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 26, 2018

💔 Build Failed

Uh oh!

tibmt commented Oct 29, 2018

Uh oh!

elasticmachine commented Nov 6, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Nov 8, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Nov 8, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Nov 8, 2018

💔 Build Failed

Uh oh!

pavel06081991 commented Nov 8, 2018

tibmt commented Oct 23, 2018 •

edited by maryia-lapata

Loading