Merge latest bits from 'main' branch into extensions branch #75090

Workaround failure to declare GenerateManifests as a dependency of _CopyResolvedFilesToPublishPreserveNewest

* wip * wip * wip * fix * more fixes * testing more changes * trying another thing out * another try * last few fixes * Update azure-pipelines-integration-dartlab.yml Co-authored-by: Joey Robichaud <jorobich@microsoft.com> --------- Co-authored-by: Joey Robichaud <jorobich@microsoft.com>

Fix handling default copilot option values

* Remove last custom ref test assemblies * more * more * more * more

…dProblem Double check document changes when dismiss rename

…stemProject.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>

…torTests.cs

Load analyzers and generators in isolated ALCs in our OOP process

…wNamespaces (dotnet#74865)

update configs for snap

…#74844)

Move host outputs from EA.Razor to Microsoft.CodeAnalysis as experimental - Change signature from (string, string) to (string, object) - Disable host outputs in batch compilers - Shim EA implementations - Add tests

…dler

…ters (dotnet#74914)

- Updated EX.Xaml to allow external client capability checks

…henRename Always take ownership from UIThreadContext when rename commit

…dler

…andler

…orkspaces.csproj

… into removeFolder

Add IRelatedDocumentsService EA wrapper for Copilot

…etryService.cs

Added LSP support for document color requests

…rovider.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>

…oteProcessTelemetryService.cs

Ensure rename cancellation is synchronous

…r spread optimization (dotnet#74949)

…kspaceExtensions.projitems

Update PublishData after vs snap

…devkit Use ignore case to fix analyzer reloading in devkit

Will help find underlying issue for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2136005 CPS has a system to catch exceptions from code they call into and have created this bug with a callstack and essentially no additional information about the exception being thrown. The hope here is that our reporting system will give us more actionable data.

* Allow ref enumerators in async/iterator methods * Report langversion errors * Remove the error message resource

)

…otnet#74969)

* Update dependencies from https://github.com/dotnet/arcade build 20240820.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24416.2 -> To Version 9.0.0-beta.24420.6 * Update dependencies from https://github.com/dotnet/arcade build 20240821.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24420.6 -> To Version 9.0.0-beta.24421.2 * Update dependencies from https://github.com/dotnet/arcade build 20240821.7 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24421.2 -> To Version 9.0.0-beta.24421.7 * Failed to perform coherency update for one or more dependencies. * Update dependencies from https://github.com/dotnet/arcade build 20240823.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24421.7 -> To Version 9.0.0-beta.24423.2 * Failed to perform coherency update for one or more dependencies. * Update dependencies from https://github.com/dotnet/arcade build 20240826.3 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24423.2 -> To Version 9.0.0-beta.24426.3 * Work around WPF resource corruption This inserts a work around for a WPF bug in preview 7. Removing this work around is tracked by the following issue dotnet#74923 * Failed to perform coherency update for one or more dependencies. * Path casing issue * Update dependencies from https://github.com/dotnet/arcade build 20240829.3 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24426.3 -> To Version 9.0.0-beta.24429.3 * Update dependencies from https://github.com/dotnet/arcade build 20240829.5 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24429.3 -> To Version 9.0.0-beta.24429.5 * Failed to perform coherency update for one or more dependencies. --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Jared Parsons <jared@paranoidcoding.org>

…cess"

…AndSpellCheck Expose Go To Impl and Spell Check to Razor

Revert "Load analyzers and generators in isolated ALCs in our OOP process"

…otnet#73861)

…74986) Probably fixes a lot of reports of dotnet#54556

The LoadProjectFileAsync routine calls EnsureMSBuildLoaded to make sure the Microsoft.Build.dll is accessible, but requires types from that assembly within the routine itself. This may not always work with Mono, as the JIT may look up the types during compilation. Fixed by splitting out a LoadProjectFileCoreAsync routine, similarly to what is already done for GetProjectsInSolution. Fixes dotnet/runtime#101121. Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>

This method is only used in one place, only wraps one method call, and can cause people to accidentally select the wrong method in RELEASE mode. I've just inlined the content and removed the method.

* Fix exception case in compiler resolver This fixes how we deal with exceptions in the compiler assembly resolver. * better exception semantics

* Update dependencies from https://github.com/dotnet/arcade build 20240903.1 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24429.5 -> To Version 9.0.0-beta.24453.1 * Failed to perform coherency update for one or more dependencies. --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Another round of CodeQL suppressions

….LazyStaleCompilationWithGeneratedDocuments (dotnet#75001) * Remove strong the cancellation token used in the calculation of InProgressState.LazyStaleCompilationWithGeneratedDocuments This will hopefully address multiple recent feedback tickets around Go To Definition occasionally failing. The umbrella pri 0 feedback ticket is https://developercommunity.visualstudio.com/t/Go-to-definition-doesnt-work/10729503 I was able to reproduce this by following the repro outlined by Garry in the feedback ticket, using the "Code Search" window and doing go to definition multiple times. The issue here is that RegularCompilationTracker.FinalizeCompilationWorkerAsync tries to get the value from the Lazy inProgressState.LazyStaleCompilationWithGeneratedDocuments. This lazy holds onto an action that uses a CancellationToken that has already been cancelled, whereas the CancellationToken used by FinalizeCompilationWorkerAsync has not been cancelled. When the action for the lazy is performed, the corresponding OperationCanceledException ends up escaping out of FinalizeCompilationWorker due to the FatalError.ReportAndPropagateUnlessCanceled exception clause failing due to the cancellation token passed into FinalizeCompilationWorkerAsync not being in a cancelled state. The offending Lazy is constructed by RegularCompilationTracker.WithDoNotCreateCreationPolicy's call to the InProgressState ctor. Instead of passing a closure capturing a cancellation token, I've changed the code to instead use CancellableLazy, which takes in a cancellation token at the time the value is requested.

…-to-date when reporting rude edits

…tnet#75020) I was looking at this code when inspecting tasks remaining during shutdown. Using Ticks means this code pretty much calls Listener.Delay on every loop iteration.

Preserve trailing trivia when replacing method with property

Use ordinal ignore case for opening pdb source documents

…#74899) * Handle infinite cycles through params collection initializers * Remove an incorrect assert * Compare whole syntax nodes * Add more tests * Add a test * Verify IOperation and flow graph * Re-add a limited assert * Test constructor+Add cycles * Move a test class from Emit2 to Emit3 To avoid error CS8103: Combined length of user strings used by the program exceeds allowed limit.

)

Expose sourcelink option to VSCode

Fix issue where closing sourcelink document threw if not opened

…909.6 (dotnet#75040) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24453.1 -> To Version 9.0.0-beta.24459.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…74498) * Allow suppressing ref ternary operands * Allow suppressing the whole ref ternary * Allow suppressing ref foreach * Use type inference for ref ternary nullability * Meet annotation and state * Move local function to the end * Keep the states joined * Test ref assignment * Skip failing test

* Remove MS.CA.Test.Resources.Proprietary This package is the last remnants of the roslyn-internal repository. It was still holding onto a few test assets that never got ported into the open but were available through the NuPkg reference. This package is becoming a problem with component governance as it is a `netstandard1.3` package and hence brings in a lot of vulnerable components. Considered upgrading this package to `netstandard2.0` but that would mean un-archiving the roslyn-internal repo, finding a place to put the source code and setting up a new official pipeline for the package. That is a pretty high price. Instead I decided to finish the work that I should've completed a number of years ago. Yes this does add a few more .dll into our git tree. These are files that haven't changed in 10+ years so versioning won't be an issue. They were all brought down already for restore hence it's not new files.

…member access expression (dotnet#74966) * Rework how inline statement snippets determine if they are valid on a position to handle member access expression case * Reference assemblies

Fix preview refresh on selection for enum flags checkboxes

Configure release/vscode branch for nuget publishing

Closes dotnet#74785.

…et#75038) Co-authored-by: deepakrathore33 <v-deerathore@microsfot.com>

…tion Lock translation of strings used to demonstrate identifier naming styles

We still had a reference to gitter, so I removed it.

Commits on Sep 13, 2024

Resolve merge conflicts

jcouv committed Sep 13, 2024

Configuration menu

View commit details

Copy full SHA for f2d4c27

Browse repository at this point

Copy the full SHA

f2d4c27 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge latest bits from 'main' branch into extensions branch #75090

Merge latest bits from 'main' branch into extensions branch #75090

Commits on Aug 26, 2024

Commits on Aug 27, 2024

Commits on Aug 28, 2024

Commits on Aug 29, 2024

Commits on Aug 30, 2024

Commits on Aug 31, 2024

Commits on Sep 2, 2024

Commits on Sep 3, 2024

Commits on Sep 4, 2024

Commits on Sep 5, 2024

Commits on Sep 6, 2024

Commits on Sep 8, 2024

Commits on Sep 9, 2024

Commits on Sep 10, 2024

Commits on Sep 11, 2024

Commits on Sep 12, 2024

Commits on Sep 13, 2024