Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest bits from 'main' branch into extensions branch #75090

Merged
merged 1,213 commits into from
Sep 17, 2024

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Sep 12, 2024

Relates to test plan #66722

The last commit resolves conflicts.
@gundermanc @CyrusNajmabadi The two updated LSIF tests were pretty cryptic to me so I just updated the baseline but wasn't able to tell whether it's good.

CyrusNajmabadi and others added 30 commits August 26, 2024 09:08
Workaround failure to declare GenerateManifests as a dependency of _CopyResolvedFilesToPublishPreserveNewest
* wip

* wip

* wip

* fix

* more fixes

* testing more changes

* trying another thing out

* another try

* last few fixes

* Update azure-pipelines-integration-dartlab.yml

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>

---------

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Fix handling default copilot option values
JoeRobich and others added 3 commits September 12, 2024 10:35
…tion

Lock translation of strings used to demonstrate identifier naming styles
We still had a reference to gitter, so I removed it.
@jcouv jcouv self-assigned this Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs UX Triage Needs API Review Needs to be reviewed by the API review council labels Sep 12, 2024
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 12, 2024
@gundermanc
Copy link
Member

Relates to test plan #66722

The last commit resolves conflicts. @gundermanc @CyrusNajmabadi The two updated LSIF tests were pretty cryptic to me so I just updated the baseline but wasn't able to tell whether it's good.

@jcouv, it looks fine to me at a glance. The integer arrays shouldn't change but I'd expect any changes to Roslyn classification type names to appear in the capabilities node for the LSIF generator.

@CyrusNajmabadi
Copy link
Member

I'm on vacation. And @jasonmalinowski knows lsif better than I do :-)

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes under Compilers LGTM, assuming CI is passing.

@jcouv
Copy link
Member Author

jcouv commented Sep 16, 2024

@jasonmalinowski Please take a look at a couple of IDE/LSIF tests updated. Thanks

Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE changes look good.

@jcouv jcouv merged commit 87df3d7 into dotnet:features/roles Sep 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Needs API Review Needs to be reviewed by the API review council Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.