Workaround failure to declare GenerateManifests as a dependency of _CopyResolvedFilesToPublishPreserveNewest #74842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opyResolvedFilesToPublishPreserveNewest
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Cosifne
reviewed
Aug 21, 2024
| @@ -395,5 +395,8 @@ | |||
| <!-- Workaround for an issue where nested targets (e.g. GetCopyToPublishDirectoryItems in the SDK) call _SplitProjectReferencesByFileExistence without calling implict prerequisite AssignProjectConfiguration --> | |||
| <Target Name="Workaround_SplitProjectReferencesByFileExistence" BeforeTargets="_SplitProjectReferencesByFileExistence" DependsOnTargets="AssignProjectConfiguration" /> | |||
|
|
|||
| <!-- Workaround for an issue where nested targets (e.g. CopyFilesToPublishDirectory in the SDK) call _CopyResolvedFilesToPublishPreserveNewest without calling implict prerequisite GenerateManifests --> | |||
There was a problem hiding this comment.
Is there any link for this issue? maybe add that in the comment
There was a problem hiding this comment.
fwiw, I reported similar msbuild ordering issues and it sounds like it's hard to fix: dotnet/msbuild#10306
adding a constraints to target order has been a surprisingly breaking operation in the past due to how people have hooked the fragile existing system.
Cosifne
approved these changes
Aug 21, 2024
CyrusNajmabadi
approved these changes
Aug 21, 2024
|
we really shoudl ve filing bugs and pushing on partner teams to fix. We can pull in @arkalyanms if needed :) |
Open
3 tasks
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.