Fix issue where closing sourcelink document threw if not opened #75046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
force-pushed
the
fix_sourcelink_not_opened
branch
from
fe3855c to
9aca3af
Compare
arunchndr
approved these changes
Sep 10, 2024
dibarbet
force-pushed
the
fix_sourcelink_not_opened
branch
from
9aca3af to
59b5770
Compare
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Sep 10, 2024
Fix issue where closing sourcelink document threw if not opened
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#7514
Essentially it is possible in LSP that
TryRemoveDocumentFromWorkspacegets called withoutTryAddDocumentToWorkspacegetting called first. This commonly happens if a sourcelink document is opened, but immediately closed - LSP will not attempt to callTryAddDocumentToWorkspaceuntil a feature requiring aSolutionis requested. If the document is immediately closed this never happens, but we would still attempt to close the document in the MAS workspace.This matches what the decompilation provider does as well
https://github.com/dotnet/roslyn/blob/main/src/Features/Core/Portable/MetadataAsSource/DecompilationMetadataAsSourceFileProvider.cs#L321