Skip to content

Conversation

genlu
Copy link
Member

@genlu genlu commented Aug 29, 2024

No description provided.

@genlu genlu requested a review from a team as a code owner August 29, 2024 00:24
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 29, 2024

namespace Microsoft.CodeAnalysis.ExternalAccess.Copilot.Internal.RelatedDocuments;

[ExportLanguageService(typeof(ICopilotRelatedDocumentsService), language: LanguageNames.CSharp), Shared]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to only export for c#?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no VB consumer, plus we only have a C# implementation for this, right?

[Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
public CSharpCopilotRelatedDocumentsService()
{
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider primary constructor form.

@genlu genlu merged commit ba9e683 into dotnet:main Aug 29, 2024
25 checks passed
@genlu genlu deleted the RelatedDocsEA branch August 29, 2024 18:00
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 29, 2024
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants