Skip to content

Added LSP support for document color requests #74933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2024
Merged

Added LSP support for document color requests #74933

merged 3 commits into from
Aug 29, 2024

Conversation

mgoertz-msft
Copy link
Contributor

@mgoertz-msft mgoertz-msft commented Aug 28, 2024 •
edited
Loading

  • Updated LSP protocol types for document color support
  • Updated EA.Xaml to allow external client capability checks

@mgoertz-msft
- Updated LSP protocol types for document color support
6ce4397 
- Updated EX.Xaml to allow external client capability checks
@mgoertz-msft mgoertz-msft requested a review from a team as a code owner August 28, 2024 19:04
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 28, 2024
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Aug 28, 2024
@dibarbet
Copy link
Member

@mgoertz-msft FYI some merge conflicts (probably b/c of a recent change to add all the 3.17 LSP types).

@mgoertz-msft
Copy link
Contributor Author

Yeah, I noticed that as soon as I created it. :(

@mgoertz-msft
Copy link
Contributor Author

@dibarbet Resolved. I was able to just take everything from Main. Only EA.Xaml changes left now. :)

cc @etvorun

@mgoertz-msft
Copy link
Contributor Author

@dibarbet Looks like infrastructure errors now. There are no test failures on the Azure pipelines.

@build-analysis build-analysis bot mentioned this pull request Aug 29, 2024
Closed
3 tasks
@dibarbet dibarbet enabled auto-merge August 29, 2024 17:56
@dibarbet dibarbet merged commit c39d594 into dotnet:main Aug 29, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 29, 2024
This was referenced Sep 6, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Closed
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.12 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoertz-msft @dibarbet @akhera99