Added LSP support for document color requests #74933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgoertz-msft
commented
Aug 28, 2024
•
mgoertz-msft
commented
- Updated LSP protocol types for document color support
- Updated EA.Xaml to allow external client capability checks
- Updated EX.Xaml to allow external client capability checks
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
|
@mgoertz-msft FYI some merge conflicts (probably b/c of a recent change to add all the 3.17 LSP types). |
|
Yeah, I noticed that as soon as I created it. :( |
|
@dibarbet Looks like infrastructure errors now. There are no test failures on the Azure pipelines. |
3 tasks
dibarbet
approved these changes
Aug 29, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.