Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProjectInfo.WithId public API #74664

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add ProjectInfo.WithId public API #74664

merged 1 commit into from
Aug 31, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 6, 2024

Useful for dotnet-watch, where we need to take ProjectInfo returned MSBuildProjectLoader and remap its ID to a project with the same project file path.

Implements #74665

@tmat tmat requested review from a team as code owners August 6, 2024 21:46
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 6, 2024
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels Aug 6, 2024
@tmat
Copy link
Member Author

tmat commented Aug 6, 2024

@dotnet/roslyn-ide @CyrusNajmabadi ptal

@tmat tmat merged commit cb6ef38 into dotnet:main Aug 31, 2024
25 checks passed
@tmat tmat deleted the WithId branch August 31, 2024 00:31
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 31, 2024
@tmat tmat mentioned this pull request Aug 31, 2024
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants