Skip to content

[Merged by Bors] - remove unnecessary unsafe impl of Send+Sync for ParallelSystemContainer #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jakobhellermann
Copy link
Contributor

ParallelSystemContainer has no !Send or !Sync fields, so it doesn't need unsafe impls of these traits.

@jakobhellermann jakobhellermann added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Jun 29, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 29, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 29, 2022
…ainer` (#5137)

`ParallelSystemContainer` has no `!Send` or `!Sync` fields, so it doesn't need unsafe impls of these traits.
@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build failed:

@alice-i-cecile
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jun 29, 2022
…ainer` (#5137)

`ParallelSystemContainer` has no `!Send` or `!Sync` fields, so it doesn't need unsafe impls of these traits.
@bors bors bot changed the title remove unnecessary unsafe impl of Send+Sync for ParallelSystemContainer [Merged by Bors] - remove unnecessary unsafe impl of Send+Sync for ParallelSystemContainer Jun 29, 2022
@bors bors bot closed this Jun 29, 2022
@jakobhellermann jakobhellermann deleted the remove-unused-unsafe-impl branch July 1, 2022 06:46
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
…ainer` (bevyengine#5137)

`ParallelSystemContainer` has no `!Send` or `!Sync` fields, so it doesn't need unsafe impls of these traits.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…ainer` (bevyengine#5137)

`ParallelSystemContainer` has no `!Send` or `!Sync` fields, so it doesn't need unsafe impls of these traits.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…ainer` (bevyengine#5137)

`ParallelSystemContainer` has no `!Send` or `!Sync` fields, so it doesn't need unsafe impls of these traits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants