-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Merged by Bors] - Rename Color::as_hlsa_f32 to Color::as_hsla_f32 #4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
May 22, 2022
james7132
approved these changes
May 22, 2022
bjorn3
approved these changes
May 22, 2022
IceSentry
approved these changes
May 23, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 23, 2022
# Objective Make the function consistent with returned values and `as_hsla` method Fixes #4826 ## Solution - Rename the method ## Migration Guide - Rename the method
Build failed: |
ManevilleF
pushed a commit
to ManevilleF/bevy
that referenced
this pull request
May 25, 2022
# Objective Make the function consistent with returned values and `as_hsla` method Fixes bevyengine#4826 ## Solution - Rename the method ## Migration Guide - Rename the method
bors retry |
bors bot
pushed a commit
that referenced
this pull request
May 25, 2022
# Objective Make the function consistent with returned values and `as_hsla` method Fixes #4826 ## Solution - Rename the method ## Migration Guide - Rename the method
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Make the function consistent with returned values and `as_hsla` method Fixes bevyengine#4826 ## Solution - Rename the method ## Migration Guide - Rename the method
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Make the function consistent with returned values and `as_hsla` method Fixes bevyengine#4826 ## Solution - Rename the method ## Migration Guide - Rename the method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make the function consistent with returned values and
as_hsla
methodFixes #4826
Solution
Migration Guide