slider widget track click position UiScale fix
#19676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`trigger.event().pointer_location.position` uses logical window coordinates: `position = physical_position / window_scale_factor` while `ComputedNodeTarget::scale_factor` returns the window scale factor multiplied by Ui Scale. `target_scale_factor = window_scale_factor * ui_scale` So to get the physical position needs: ``` position * target_scale_factor / ui_scale = (physical_postion / window_scale_factor) * (window_scale_factor * ui_scale) / ui_scale = physical_position ```
alice-i-cecile
approved these changes
Jun 16, 2025
alice-i-cecile
added
C-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The position for track clicks in
core_slideris calculated incorrectly when usingUiScale.Solution
trigger.event().pointer_location.positionuses logical window coordinates, that is:position = physical_position / window_scale_factorwhile
ComputedNodeTarget::scale_factorreturns the window scale factor multiplied by Ui Scale:target_scale_factor = window_scale_factor * ui_scaleSo to get the physical position need to divide by the
UiScale:I thought this was fixed during the slider PR review, but must have got missed somewhere or lost in a merge.
Testing
Can test using the
core_widgetsexamplewith.insert_resource(UiScale(2.))` added to the bevy app.