Remove re-exports of cosmic_text types #19516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
viridia
approved these changes
Jun 6, 2025
7 tasks
alice-i-cecile
added
S-Ready-For-Final-Review
BenjaminBrienen
approved these changes
Jun 6, 2025
SpecificProtagonist
suggested changes
Jun 6, 2025
There was a problem hiding this comment.
please rely on them directly from
cosmic_text, being sure that the version number you are using matches the version used by your version ofbevy_text.
Standard practice – which we are currently following, see the self in the import – would be to reëxport cosmic_text as bevy_text::cosmic_text to avoid this problem.
Indeed, but I think the cure is worse than the disease here, and the others in the linked thread agree. |
alice-i-cecile
added
X-Contentious
VitalyAnkh
pushed a commit
to VitalyAnkh/bevy
that referenced
this pull request
Jun 8, 2025
# Objective As discussed in bevyengine#19285, we do a poor job at keeping the namespace tidy and free of duplicates / user-conflicting names in places. `cosmic_text` re-exports were the worst offender. ## Solution Remove the re-exports completely. While the type aliases were quite thoughtful, they weren't used in any of our code / API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
As discussed in #19285, we do a poor job at keeping the namespace tidy and free of duplicates / user-conflicting names in places.
cosmic_textre-exports were the worst offender.Solution
Remove the re-exports completely. While the type aliases were quite thoughtful, they weren't used in any of our code / API.