-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix EntityCloner
replacing required components.
#19326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EntityCloner
replacing required components.
#19326
Conversation
…l components when filtering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice that this does not come with an API change.
I wonder if this can be extended a bit. If you could manually populate the new An API do allow/deny by |
Yeah, that could be useful. Although I don't think new API is supposed to be introduced in patch releases, so I think it's better to leave this PR just as a bugfix for |
# Objective Fix #19324 ## Solution `EntityCloner` replaces required components when filtering. This is unexpected when comparing with the way the rest of bevy handles required components. This PR separates required components from explicit components when filtering in `EntityClonerBuilder`. ## Testing Added a regression test for this case.
# Objective Fix #19324 ## Solution `EntityCloner` replaces required components when filtering. This is unexpected when comparing with the way the rest of bevy handles required components. This PR separates required components from explicit components when filtering in `EntityClonerBuilder`. ## Testing Added a regression test for this case.
Objective
Fix #19324
Solution
EntityCloner
replaces required components when filtering. This is unexpected when comparing with the way the rest of bevy handles required components. This PR separates required components from explicit components when filtering inEntityClonerBuilder
.Testing
Added a regression test for this case.