Add a despawn_children method to EntityWorldMut and EntityCommands #19283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
C-Feature
bushrat011899
approved these changes
May 18, 2025
Contributor
bushrat011899
left a comment
bushrat011899
left a comment
There was a problem hiding this comment.
I personally don't see the harm in including these methods, and they're likely a good candidate for 0.16.1 as well. Just a couple nit-level changes to documentation to ensure users understand these are just helpers for the more general despawn_related.
Co-authored-by: Zachary Harrold <zac@harrold.com.au>
Co-authored-by: Zachary Harrold <zac@harrold.com.au>
Contributor
Author
|
Thanks for the feedback, I applied your tweaks. |
urben1680
approved these changes
May 27, 2025
chescock
added
S-Ready-For-Final-Review
This was referenced Jun 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 15, 2025
# Objective - `remove_child` was mentioned missing in #19556 and I realized that `insert_child` was also missing. - Removes the need to wrap a single entity with `&[]` with `remove_children` and `insert_children` - Would have also added `despawn_children` but #19283 does so. ## Solution - Simple wrapper around `remove_related` ## Testing - Added `insert_child` and `remove_child` tests analgous to `insert_children` and `remove_children` and then ran `cargo run -p ci -- test`
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
At the moment, if someone wants to despawn all the children of an entity, they would need to use
despawn_related::<Children>();.In my opinion, this makes a very common operation less easily discoverable and require some understanding of Entity Relationships.
Solution
Adding a
despawn_childrenmakes a very simple, discoverable and readable way to despawn all the children while maintaining cohesion with other similar methods.Testing
The implementation itself is very simple as it simply wraps around
despawn_relatedwithChildrenas the generic type.I gave it a quick try by modifying the parenting example and it worked as expected.