-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Add test for mipmap filters #19095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add test for mipmap filters #19095
Conversation
We should try and fix this.
Renderer test if we're going to be doing rendering and screenshots. Like you say, gltf loading should be tested purely in headless code. |
GltfLoaderSettings::override_sampler
and mipmap rendering
Test has been redone to focus on rendering - glTF testing is now just a bonus. Also added CI support. In the longer-term I'm guessing this test should be redone as BSN scenes, and the glTF part would be split off and made headless. But I'm hoping the current choices are acceptable for the short-term. |
Objective
Add a test for mipmap filters, and as a bonus test
GltfLoaderSettings::override_sampler
. Neither of these are covered by current tests or examples.Solution
gltf_override_sampler.mp4
The test supports CI screenshots, although I haven't added it to the CI config.
Problems
It's currently broken.
GltfLoaderSettings::override_sampler
.faefb8dd
.Combining two tests into one is debatable.
GltfLoaderSettings::override_sampler
is convenient and provides a test case for Gltf assets do not reload correctly #18267.CI screenshot boilerplate.
testbed/helpers.rs
.Testing
Tested on Win10/Nvidia, across Desktop/Vulkan, Chrome/WebGL, Chrome/WebGPU.