Skip to content

UI render graph setup refactor #18983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Apr 29, 2025

Objective

  • The get_ui_graph function in bevy_ui's render module is misnamed. It doesn't get the graph, it creates a new one.
  • get_ui_graph shouldn't be called until after we've retrieved each subgraph, otherwise the new UI graph is created for nothing.

Solution

  • Rename get_ui_graph to new_ui_graph
  • Call new_ui_graph only after each subgraph is successful retrieved from the render graph.

Call `new_ui_graph` only after we've successfully retrieved the relevant subgraphs.
@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Apr 29, 2025
@ickshonpe ickshonpe added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants