Fix occlusion culling not respecting device limits #18974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
approved these changes
Apr 29, 2025
JMS55
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
approved these changes
May 5, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The occlusion culling plugin checks for a GPU feature by looking at
RenderAdapter. This is wrong - it should be checkingRenderDevice. See these notes for background: #18973I don't have any evidence that this was causing any bugs, so right now it's just a precaution.
Testing
Tested on Win10/Nvidia across Vulkan, WebGL/Chrome, WebGPU/Chrome.