Make sure the mesh actually exists before we try to specialize. #18836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
C-Bug
JMS55
approved these changes
Apr 13, 2025
IceSentry
approved these changes
Apr 14, 2025
IceSentry
added
S-Ready-For-Final-Review
atlv24
approved these changes
Apr 14, 2025
superdump
approved these changes
Apr 14, 2025
mockersf
pushed a commit
that referenced
this pull request
Apr 14, 2025
Fixes #18809 Fixes #18823 Meshes despawned in `Last` can still be in visisible entities if they were visible as of `PostUpdate`. Sanity check that the mesh actually exists before we specialize. We still want to unconditionally assume that the entity is in `EntitySpecializationTicks` as its absence from that cache would likely suggest another bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18809
Fixes #18823
Meshes despawned in
Lastcan still be in visisible entities if they were visible as ofPostUpdate. Sanity check that the mesh actually exists before we specialize. We still want to unconditionally assume that the entity is inEntitySpecializationTicksas its absence from that cache would likely suggest another bug.