Add binned 2d/3d Wireframe render phase #18587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
C-Bug
tychedelia
changed the title
|
And #17737 ? |
IceSentry
approved these changes
Mar 31, 2025
JMS55
suggested changes
Apr 1, 2025
| color: vec4<f32>, | ||
| }; | ||
| struct PushConstants { | ||
| color: vec4<f32> |
There was a problem hiding this comment.
FYI push constants aren't available on WebGPU. Idk how we feel about requiring them for wireframes.
There was a problem hiding this comment.
Wireframes require the POLYGON_MODE_LINE feature which isn't available on web.
BenjaminBrienen
approved these changes
Apr 6, 2025
There was a problem hiding this comment.
before
2025-04-06T19:46:04.258711Z INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Linux (Pop!_OS 22.04)", kernel: "6.12.10-76061203-generic", cpu: "AMD Ryzen 9 7950X 16-Core Processor", core_count: "16", memory: "61.9 GiB" }
2025-04-06T19:46:04.402175Z INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 3070", vendor: 4318, device: 9348, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "565.77", backend: Vulkan }
2025-04-06T19:46:04.943835Z INFO bevy_winit::system: Creating new window wireframe (0v1)
2025-04-06T19:46:04.943952Z INFO winit::platform_impl::linux::x11::window: Guessed window scale factor: 2
2025-04-06T19:46:05.323457Z WARN bevy_render::view::window: Couldn't get swap chain texture after configuring. Cause: 'The underlying surface has changed, and therefore the swap chain must be updated'
2025-04-06T19:46:05.349754Z WARN bevy_render::view::window: Couldn't get swap chain texture after configuring. Cause: 'The underlying surface has changed, and therefore the swap chain must be updated'
2025-04-06T19:46:21.165852Z INFO bevy_window::system: No windows are open, exiting
2025-04-06T19:46:21.168408Z INFO bevy_winit::system: Closing window 0v1
after
2025-04-06T19:43:56.514546Z INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Linux (Pop!_OS 22.04)", kernel: "6.12.10-76061203-generic", cpu: "AMD Ryzen 9 7950X 16-Core Processor", core_count: "16", memory: "61.9 GiB" }
2025-04-06T19:43:56.663878Z INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 3070", vendor: 4318, device: 9348, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "565.77", backend: Vulkan }
2025-04-06T19:43:57.231557Z INFO bevy_winit::system: Creating new window App (0v1)
2025-04-06T19:43:57.231678Z INFO winit::platform_impl::linux::x11::window: Guessed window scale factor: 2
2025-04-06T19:43:57.497651Z WARN bevy_render::view::window: Couldn't get swap chain texture after configuring. Cause: 'The underlying surface has changed, and therefore the swap chain must be updated'
2025-04-06T19:43:57.538660Z WARN bevy_render::view::window: Couldn't get swap chain texture after configuring. Cause: 'The underlying surface has changed, and therefore the swap chain must be updated'
2025-04-06T19:44:01.095167Z WARN bevy_render::view::window: Couldn't get swap chain texture after configuring. Cause: 'The underlying surface has changed, and therefore the swap chain must be updated'
2025-04-06T19:44:07.322743Z INFO bevy_window::system: No windows are open, exiting
2025-04-06T19:44:07.325725Z INFO bevy_winit::system: Closing window 0v1
BenjaminBrienen
added
S-Ready-For-Final-Review
superdump
reviewed
Apr 6, 2025
superdump
reviewed
Apr 6, 2025
superdump
approved these changes
Apr 9, 2025
mockersf
pushed a commit
that referenced
this pull request
Apr 9, 2025
# Objective Fixes #16896 Fixes #17737 ## Solution Adds a new render phase, including all the new cold specialization patterns, for wireframes. There's a *lot* of regrettable duplication here between 3d/2d. ## Testing All the examples. ## Migration Guide - `WireframePlugin` must now be created with `WireframePlugin::default()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16896
Fixes #17737
Solution
Adds a new render phase, including all the new cold specialization patterns, for wireframes. There's a lot of regrettable duplication here between 3d/2d.
Testing
All the examples.
Migration Guide
WireframePluginmust now be created withWireframePlugin::default().