Fix lints and re-organize gated imports for bevy_gizmos#18487
Open
villor wants to merge 1 commit into
Open
Conversation
Contributor
|
|
Contributor
Author
It does actually! If you don't specify anything it will "Execute all unit and integration tests and build examples of a local package" So unless you specify targets with something like $ cargo test -p bevy_gizmos
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.29s
Running unittests src/lib.rs (target/debug/deps/bevy_gizmos-ae878401ca04cf3e)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests bevy_gizmos
running 46 tests
test crates/bevy_gizmos/src/arrows.rs - arrows::GizmoBuffer<Config,Clear>::arrow (line 114) ... ok
test crates/bevy_gizmos/src/arcs.rs - arcs::GizmoBuffer<Config,Clear>::short_arc_2d_between (line 337) ... ok
# ...
test crates/bevy_gizmos/src/lib.rs - (line 10) ... ok
test crates/bevy_gizmos/src/rounded_box.rs - rounded_box::GizmoBuffer<Config,Clear>::rounded_rect_2d (line 307) ... ok
test result: ok. 46 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s |
Contributor
|
Ah, cool |
alice-i-cecile
requested changes
Mar 23, 2025
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Good cleanup and fixes, but I find using _ variable names confusing for cfg-gated fields and values. I'd prefer feature-gated expects for dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_gizmoshas lint errors on some feature combinations.use-declarations are a bit of a messSolution
bevy_pbr/bevy_spritefeatures.use-declarations inlib.rsinto more reasonable blocks (still a bit of a mess, but now less of a mess)Testing