-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix lints and re-organize gated imports for bevy_gizmos
#18487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It does actually! If you don't specify anything it will "Execute all unit and integration tests and build examples of a local package" So unless you specify targets with something like $ cargo test -p bevy_gizmos
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.29s
Running unittests src/lib.rs (target/debug/deps/bevy_gizmos-ae878401ca04cf3e)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests bevy_gizmos
running 46 tests
test crates/bevy_gizmos/src/arrows.rs - arrows::GizmoBuffer<Config,Clear>::arrow (line 114) ... ok
test crates/bevy_gizmos/src/arcs.rs - arcs::GizmoBuffer<Config,Clear>::short_arc_2d_between (line 337) ... ok
# ...
test crates/bevy_gizmos/src/lib.rs - (line 10) ... ok
test crates/bevy_gizmos/src/rounded_box.rs - rounded_box::GizmoBuffer<Config,Clear>::rounded_rect_2d (line 307) ... ok
test result: ok. 46 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s |
Ah, cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup and fixes, but I find using _ variable names confusing for cfg-gated fields and values. I'd prefer feature-gated expects for dead code.
Objective
bevy_gizmos
has lint errors on some feature combinations.use
-declarations are a bit of a messSolution
bevy_pbr
/bevy_sprite
features.use
-declarations inlib.rs
into more reasonable blocks (still a bit of a mess, but now less of a mess)Testing