Skip to content

Canonicalize the root path to match the canonicalized asset path. #18345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

Canonicalize the root path to match the canonicalized asset path. #18345

merged 1 commit into from
Mar 16, 2025

Conversation

andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Mar 16, 2025 •
edited
Loading

Objective

Solution

Testing

  • Ran the hot_asset_reloading example and it no longer panics.

@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds O-Windows Specific to the Windows desktop operating system S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 16, 2025
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 16, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Mar 16, 2025
alice-i-cecile
alice-i-cecile approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal. We really need better automated tests for bevy_assets.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 16, 2025
Merged via the queue into bevyengine:main with commit 9bcaad7 Mar 16, 2025
38 checks passed
@andriyDev andriyDev deleted the fix-hot-reload-win branch March 16, 2025 21:20
This was referenced Mar 16, 2025
Closed
Closed
This was referenced May 9, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@hukasu hukasu hukasu approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy O-Windows Specific to the Windows desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

Hot reloading on Windows is broken.
3 participants
@andriyDev @alice-i-cecile @hukasu